Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expected CloudFormation link for Armo security readonly stack #604

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Feb 3, 2025

PR Type

Bug fix


Description

  • Updated the expected CloudFormation link in the get_and_validate_cspm_link method.

  • Fixed the stack name in the expected link to match the correct value.


Changes walkthrough 📝

Relevant files
Bug fix
cspm.py
Update expected CloudFormation link in validation method 

tests_scripts/accounts/cspm.py

  • Updated the expected CloudFormation link in the
    get_and_validate_cspm_link method.
  • Changed the stack name from create-armo-scan-user to
    armo-security-readonly.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @kooomix kooomix merged commit 61217a9 into master Feb 3, 2025
    2 checks passed
    Copy link

    github-actions bot commented Feb 3, 2025

    Failed to generate code suggestions for PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant