Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip cspm test prod #597

Closed
wants to merge 2 commits into from
Closed

skip cspm test prod #597

wants to merge 2 commits into from

Conversation

jnathangreeg
Copy link
Contributor

@jnathangreeg jnathangreeg commented Jan 28, 2025

PR Type

Bug fix


Description

  • Updated description field in accounts section for clarity.

  • Added skip_on_environment to exclude specific environments.


Changes walkthrough 📝

Relevant files
Configuration changes
system_test_mapping.json
Adjust CSPM test configuration for environment exclusion 

system_test_mapping.json

  • Modified description field in the accounts section.
  • Added skip_on_environment to exclude "production" and "production-us".
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Signed-off-by: jnathangreeg <[email protected]>
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Use array instead of string

    Consider using an array format for skip_on_environment instead of comma-separated
    string to maintain consistency and prevent potential parsing issues.

    system_test_mapping.json [1205]

    -"skip_on_environment": "production,production-us",
    +"skip_on_environment": ["production", "production-us"],
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Using an array format for environment values is a better practice as it provides clearer data structure, easier parsing, and consistency with JSON array conventions, reducing potential string parsing issues.

    7

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants