support windows escaped windows paths in embedded json

Author: Bezalel Brandwine

decode_embedded_json_test.go

@@ -40,6 +40,18 @@ func TestDecodeEmbeddedJSONUnmarshalAPI(t *testing.T) {
 		expectedEmbedded string
 		err              bool
 	}{
+		{
+			name:             "windows paths escaped",
+			json:             []byte(`{"id":"someid","method":"getmydata","params":"C:\\\\ProgramData\\\\MySQL\\\\MySQL Server 8.0\\\\Data\\\\#innodb_temp\\\\", "more":123}`),
+			expectedEmbedded: `"C:\\\\ProgramData\\\\MySQL\\\\MySQL Server 8.0\\\\Data\\\\#innodb_temp\\\\"`,
+			err:              false,
+		},
+		{
+			name:             "windows paths escaped",
+			json:             []byte(`{"id":"someid","method":"getmydata","params":"C:\\\\ProgramData\\\\MySQL\\\\MySQL Server 8.0\\\\Data\\\\#innodb_temp\\\\jjjj", "more":123}`),
+			expectedEmbedded: `"C:\\\\ProgramData\\\\MySQL\\\\MySQL Server 8.0\\\\Data\\\\#innodb_temp\\\\jjjj"`,
+			err:              false,
+		},
 		{
 			name:             "decode-basic-string",
 			json:             []byte(`{"id":"someid","method":"getmydata","params":"raw data", "more":123}`),

decode_string.go

@@ -164,6 +164,7 @@ func (dec *Decoder) getString() (int, int, error) {
 	return 0, 0, dec.raiseInvalidJSONErr(dec.cursor)
 }
 
+// expecting the dec.cursor to be after the opening slash
 func (dec *Decoder) skipEscapedString() error {
 	start := dec.cursor
 	for ; dec.cursor < dec.length || dec.read(); dec.cursor++ {
@@ -173,9 +174,12 @@ func (dec *Decoder) skipEscapedString() error {
 			nSlash := dec.cursor - start
 			switch d {
 			case '"':
-				// nSlash must be odd
+				// since we expecting the start to be after the opening slash
+				// if nSlash is odd then the escaped string contains the quote
+				// if nSlash is even, the quote is outside the escaped string
 				if nSlash&1 != 1 {
-					return dec.raiseInvalidJSONErr(dec.cursor)
+					// return dec.raiseInvalidJSONErr(dec.cursor)
+					dec.cursor--
 				}
 				return nil
 			case 'u': // is unicode, we skip the following characters and place the cursor one one byte backward to avoid it breaking when returning to skipString
@@ -198,6 +202,7 @@ func (dec *Decoder) skipEscapedString() error {
 	return dec.raiseInvalidJSONErr(dec.cursor)
 }
 
+// expecting dec.cusror to be after the opening quote
 func (dec *Decoder) skipString() error {
 	for dec.cursor < dec.length || dec.read() {
 		switch dec.data[dec.cursor] {

decode_string_test.go

@@ -17,6 +17,12 @@ func TestDecoderString(t *testing.T) {
 		err            bool
 		errType        interface{}
 	}{
+		{
+			name:           "windows paths escaped",
+			json:           `"C:\\\\ProgramData\\\\MySQL\\\\MySQL Server 8.0\\\\Data\\\\#innodb_temp\\\\"`,
+			expectedResult: `C:\\ProgramData\\MySQL\\MySQL Server 8.0\\Data\\#innodb_temp\\`,
+			err:            false,
+		},
 		{
 			name:           "basic-string",
 			json:           `"string"`,
@@ -328,6 +334,12 @@ func TestDecoderStringNull(t *testing.T) {
 		errType        interface{}
 		resultIsNil    bool
 	}{
+		{
+			name:           "windows paths escaped",
+			json:           `"C:\\\\ProgramData\\\\MySQL\\\\MySQL Server 8.0\\\\Data\\\\#innodb_temp\\\\"`,
+			expectedResult: `C:\\ProgramData\\MySQL\\MySQL Server 8.0\\Data\\#innodb_temp\\`,
+			err:            false,
+		},
 		{
 			name:           "basic-string",
 			json:           `"string"`,
@@ -690,8 +702,9 @@ func TestDecoderSkipEscapedStringError2(t *testing.T) {
 	dec := NewDecoder(strings.NewReader(`\"`))
 	defer dec.Release()
 	err := dec.skipEscapedString()
-	assert.NotNil(t, err, "Err must be nil")
-	assert.IsType(t, InvalidJSONError(""), err, "err must be of type InvalidJSONError")
+	assert.Nil(t, err, "Err must be nil")
+	// assert.IsType(t, InvalidJSONError(""), err, "err must be of type InvalidJSONError")
+	assert.Equal(t, 1, dec.cursor, "dec.cursor must be 2")
 }
 
 func TestDecoderSkipEscapedStringError3(t *testing.T) {
@@ -727,14 +740,14 @@ func TestSkipString(t *testing.T) {
 		errType        interface{}
 	}{
 		{
-			name:           "escape quote err",
+			name:           "escape quote err0",
 			json:           `test string \\" escaped"`,
 			expectedResult: ``,
-			err:            true,
-			errType:        InvalidJSONError(""),
+			err:            false,
+			// errType:        InvalidJSONError(""),
 		},
 		{
-			name:           "escape quote err",
+			name:           "escape quote err1",
 			json:           `test string \\\l escaped"`,
 			expectedResult: ``,
 			err:            true,