From 3215385aeb044665f5aeedc74a22cdf6fec2e4cd Mon Sep 17 00:00:00 2001 From: John Stiles Date: Sun, 23 Aug 2020 18:30:07 -0400 Subject: [PATCH] Disable ClangTidy namespace comments for short blocks. Namespace comments don't assist readability for blocks that can easily fit on a single screen. Change-Id: I93cbebe8e51400dead794c9eb41cb1eaa86bf756 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312639 Auto-Submit: John Stiles Reviewed-by: Mike Klein Commit-Queue: John Stiles --- .clang-tidy | 2 ++ gm/pathfill.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 37e8152264c6..ce6d28b014c5 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -19,5 +19,7 @@ Checks: > readability-redundant-smartptr-get, readability-static-accessed-through-instance CheckOptions: + - key: llvm-namespace-comment.ShortNamespaceLines + value: 40 - key: llvm-namespace-comment.SpacesBeforeComments value: 2 diff --git a/gm/pathfill.cpp b/gm/pathfill.cpp index 28bef368b708..246332a05418 100644 --- a/gm/pathfill.cpp +++ b/gm/pathfill.cpp @@ -21,7 +21,7 @@ struct PathDY { SkPath path; SkScalar dy; }; -} // namespace +} typedef PathDY (*MakePathProc)();