This repository has been archived by the owner on Mar 1, 2021. It is now read-only.
Get table completion percentage #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsiehoffet-94
changed the title
Jasopaum
reviewed
Jul 27, 2020
| from sqlalchemy.exc import OperationalError | ||
| import json | ||
|
|
||
| def get_col_completion(owner, table_name, sorted, db_model): |
There was a problem hiding this comment.
Where will this be called? Do you think we should make it a route (as for get_db_schema)?
| from sqlalchemy.exc import OperationalError | ||
| import json | ||
|
|
||
| def get_col_completion(owner, table_name, sorted, db_model): |
There was a problem hiding this comment.
When do you think sorted will be useful?
| db_drivers = {"POSTGRES": POSTGRES, "ORACLE": ORACLE} | ||
|
|
||
| credentials = { | ||
| 'model': 'public', |
| for column in column_list[:-1] : | ||
| query_tmp += f"round(count({column}) / count(*) * 100, 0), " | ||
| query_tmp += f"round(count({column_list[-1]}) / count(*) * 100, 0) " | ||
| sql_query = f"select {query_tmp} from {table}" |
There was a problem hiding this comment.
Do you think we could do that with sqlAlchemy?
|
stale |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to compute column completion percentage on a table of a database with a simple sql query
select count(column)/count(*) from table.Closes #36