This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
[FhirResourceTree] Reset tree state on unmount #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonvadee
reviewed
Oct 7, 2021
Comment on lines
+248
to
+254
| useEffect(() => { | ||
| return () => { | ||
| if (!node) { | ||
| dispatch(resourceTreeSliceStateReseted()); | ||
| } | ||
| }; | ||
| }, [dispatch, node]); |
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| return () => { | |
| if (!node) { | |
| dispatch(resourceTreeSliceStateReseted()); | |
| } | |
| }; | |
| }, [dispatch, node]); | |
| useEffect(() => () => !node && dispatch(resourceTreeSliceStateReseted()), | |
| [dispatch, node]); |
There was a problem hiding this comment.
I managed to test whether this reset action has been called once when hook is unmounted
BPierrick
force-pushed
the
pb/fix_empty_complex_nodes
branch
from
259777a to
6c9131a
Compare
simonvadee
approved these changes
Oct 12, 2021
| server.listen({ onUnhandledRequest: "error" }); | ||
| }); | ||
|
|
||
| describe("useFhirResourceTreeData", () => { |
BPierrick
force-pushed
the
pb/fix_empty_complex_nodes
branch
from
6c9131a to
cac3752
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Definition of Done