Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

"Documents" section doesn't list any document in Toulouse env #113

Open
MiskoG opened this issue Jul 5, 2021 · 6 comments
Open

"Documents" section doesn't list any document in Toulouse env #113

MiskoG opened this issue Jul 5, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@MiskoG
Copy link

MiskoG commented Jul 5, 2021

Spotted by @elsiehoffet-94
image

Seems like we have a bad request on the DocumentReference FHIR endpoint.
I think there is an easy fix but I'm not sure, what do you think @simonvadee ?

@MiskoG MiskoG changed the title "Documents" section doesn't list any document "Documents" section doesn't list any document in Toulouse env Jul 5, 2021
@MiskoG MiskoG added the bug Something isn't working label Jul 5, 2021
@simonvadee
Copy link

I identified the issue, it's partly due to a mapping issue on DocumentReference and also because the cohort app is not flexible at all. I'm fixing this thanks to @Peltier10 help.

@MiskoG MiskoG removed their assignment Jul 6, 2021
@MiskoG
Copy link
Author

MiskoG commented Jul 6, 2021

Ok great ! Does fixing this imply only modifying the mapping, or also make Cohort more flexible in this case ?

@simonvadee
Copy link

simonvadee commented Jul 6, 2021

We need to modify both. Should be done tomorrow.

@simonvadee
Copy link

don't have time to finish this sorry: For @Jasopaum :
in src/components/Cohort/Documents/DocumentList/DocumentList.tsx: the file url needs to start with file:// and end with .pdf. We only use the first extension but sometimes there are multiple ones (for tls, there are three sections).
You need to adapt src/components/Cohort/Documents/PdfRenderer/PdfRenderer.tsx to accept multiple sections

@Jasopaum
Copy link

Jasopaum commented Jul 9, 2021

don't have time to finish this sorry: For @Jasopaum :
in src/components/Cohort/Documents/DocumentList/DocumentList.tsx: the file url needs to start with file:// and end with .pdf. We only use the first extension but sometimes there are multiple ones (for tls, there are three sections).
You need to adapt src/components/Cohort/Documents/PdfRenderer/PdfRenderer.tsx to accept multiple sections

I don't think this was really the answer to this issue. The problem was that the api response was an empty bundle when trying to sort on the search param date. I removed the sorting for now but we need to investigate

@MiskoG
Copy link
Author

MiskoG commented Jul 15, 2021

I removed the sorting for now but we need to investigate

@Jasopaum Can we consider this initial bug/issue as fixed ? Is there any PR associated with the sort removing ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants