Skip to content

Commit 5f8121e

Browse files
ci: move clippy step as a final touch step
Sometimes it is nice to have a fixup commit and be able to run the tests without having to pass clippy or other repo rules passing before running the e2e tests. In other works clippy is a final touch check from the code prospective, so probably make sense move to the end. Signed-off-by: Vincenzo Palazzo <[email protected]>
1 parent abb262b commit 5f8121e

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

.github/workflows/ci.yml

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,8 @@ jobs:
4141
- name: Disallow squash! commits
4242
run: git log --pretty=format:%s origin/master..HEAD | grep -zv squash!
4343

44-
clippy:
45-
runs-on: ubuntu-latest
46-
steps:
47-
- uses: actions/checkout@v4
48-
- uses: extractions/setup-just@v2
49-
- uses: dtolnay/rust-toolchain@master
50-
with:
51-
toolchain: stable
52-
- uses: Swatinem/rust-cache@v2
53-
- run: cargo clippy --all-targets --all-features -- -D warnings
54-
5544
unit-tests:
5645
runs-on: ubuntu-latest
57-
needs: [ clippy ]
5846
steps:
5947
- uses: actions/checkout@v4
6048
- uses: extractions/setup-just@v2
@@ -66,7 +54,6 @@ jobs:
6654
run: RUST_BACKTRACE=1 cargo test --workspace --exclude ark-secp256k1
6755

6856
e2e-tests:
69-
needs: [ clippy ]
7057
strategy:
7158
fail-fast: false
7259
matrix:
@@ -123,3 +110,15 @@ jobs:
123110

124111
- name: Build crates for WASM
125112
run: PATH="/opt/homebrew/opt/llvm/bin:$PATH" cargo build -p ark-core -p ark-rest --target wasm32-unknown-unknown
113+
114+
clippy:
115+
runs-on: ubuntu-latest
116+
needs: [ unit-tests, e2e-tests, wasm_ubuntu, wasm_macos ]
117+
steps:
118+
- uses: actions/checkout@v4
119+
- uses: extractions/setup-just@v2
120+
- uses: dtolnay/rust-toolchain@master
121+
with:
122+
toolchain: stable
123+
- uses: Swatinem/rust-cache@v2
124+
- run: cargo clippy --all-targets --all-features -- -D warnings

0 commit comments

Comments
 (0)