The global retryStrategy is only for Pod type (not Step/DAG template)

[shuangkun]

Summary

I hope to configure the global retryStrategy uniformly, but I don't want the Step/DAG type retry to cause the task to be re-run.

Use Cases

Very complex workflow with unified retryStrategy, do not want to configure retryStrategy in each template.
Do not want to configure memoize, which is troublesome for developers.
Do not want the retry of Steps/DAG type template to cause the completed tasks to be re-run.

---

Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

[jswxstw]

Completely agree! Setting retryStrategy uniformly in templateDefaults is simply a disaster: #13297 (comment).

[tczhao]

Maybe we can filter node type in retry expression

[shuangkun]

Maybe we can filter node type in retry expression

Yes, I tried to do that once, but couldn't find a variable to use directly. https://argo-workflows.readthedocs.io/en/latest/variables/ Maybe we need to add a variable to each template to identify which template it is.
Another way is to add a field in the retryStratepy at the workflow level, such as retryNodeType: [Steps, DAG, Container, Script, HTTP...]

[jswxstw]

Maybe we need to add a variable to each template to identify which template it is.

argo-workflows/workflow/controller/operator.go

Line 2098 in 43c6abd

if woc.retryStrategy(processedTmpl) != nil {

It seems that we only need to add a filtering condition here? Or should we add a new field or add a new retry policy in retryStrategy to control this?

processedTmpl.IsPodType() && woc.retryStrategy(processedTmpl) != nil

[shuangkun]

Yes. Whether adding filtering conditions or adding new fields, there needs to be a condition for the user to trigger. Either use expression or use retryNodeType configuration.

[jswxstw]

Completely agree! Setting retryStrategy uniformly in templateDefaults is simply a disaster: #13297 (comment).

The global retryStrategy will also cause the entire workflow topology and state to become inconsistent when hooks are used, see #13239 (comment).