Inconsistent Naming of Argo CD Objects When Installed via Helm

[romanvilu]

Describe the bug

Argo CD installation via the Helm chart results in inconsistent resource naming. Specifically, some resources respect the fullnameOverride value, while others have the argocd- prefix hardcoded. For example, the argocd-configs/argocd-secret.yaml file contains a Secret object with the fixed name argocd-secret.

Related helm chart

argo-cd

Helm chart version

7.7.2

To Reproduce

1. Download the Helm chart
2. Set the fullnameOverride value, for instance, to argo-cd
3. Install the release
4. Check the names of objects using the command:

   kubectl get all,secrets -n <namespace>
   

Expected behavior

Naming is consistent. Resources respect the fullnameOverride value.

Screenshots

No response

Additional context

A general question: in many places, Argo CD is referred to as either argo-cd or argocd. While this doesn’t cause technical issues, it can lead to confusion around naming conventions. Then, why wouldn't we refer to Argo Workflows as either argo-workflows or argoworkflows?

It might be beneficial to standardize naming across configurations and documentation for clarity and consistency.

[yu-croco]

Hi @romanvilu

while others have the argocd- prefix hardcoded. For example, the argocd-configs/argocd-secret.yaml file contains a Secret object with the fixed name argocd-secret.

This is because Argo CD fetches the hardcoded names in upstream.
e.g.) https://github.com/argoproj/argo-cd/blob/master/common/common.go#L35-L50