Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigMap/argocd-notifications-cm is empty in default install. Should be filled official template instead for out-of-box-experience. #21315

Open
kazuki-ma opened this issue Dec 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kazuki-ma
Copy link

kazuki-ma commented Dec 25, 2024

Summary

Add default notification template to install manifest.

Motivation

When I tried setup notifications, I noticed argocd-notifications-cm is exist by default but it's empty.
Yes. It's well documented in getting-started. But I see no particular reason to install manually.

And, more importantly, empty configMap is contained in default install.yaml manifest.

That means notifications-cm will be easily reset to empty by operation mistake (like update ArgoCD by upsert install manifest)

Proposal

Add notification templates into default install manifest.
(or remove empty argocd-notifications-cm from install manifest.)

@kazuki-ma kazuki-ma added the enhancement New feature or request label Dec 25, 2024
@kazuki-ma kazuki-ma changed the title argocd-notifications-cm.yaml is empty by default install. Should be filled official template instead for out-of-box-experience. ConfigMap/argocd-notifications-cm is empty by default install. Should be filled official template instead for out-of-box-experience. Dec 25, 2024
@kazuki-ma kazuki-ma changed the title ConfigMap/argocd-notifications-cm is empty by default install. Should be filled official template instead for out-of-box-experience. ConfigMap/argocd-notifications-cm is empty in default install. Should be filled official template instead for out-of-box-experience. Dec 25, 2024
@andrii-korotkov-verkada
Copy link
Contributor

I think it used to be like this, but was changed. My understanding is there's simply no catch-all notification template due to many notifications methods used. You can create an overlay with copying some from notifications catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants