feat: allow overriding several paths when updating tag

Signed-off-by: Tchoupinax <[email protected]>

Author: Tchoupinax

pkg/argocd/argocd.go

@@ -418,12 +418,30 @@ func SetHelmImage(app *v1alpha1.Application, newImage *image.ContainerImage) err
 		mergeParams = append(mergeParams, p)
 	} else {
 		if hpImageName != "" {
-			p := v1alpha1.HelmParameter{Name: hpImageName, Value: newImage.GetFullNameWithoutTag(), ForceString: true}
-			mergeParams = append(mergeParams, p)
+			// Here is the case value1,value2
+			if strings.Contains(hpImageName, ",") {
+				var parameters = strings.Split(hpImageName, ",")
+				for _, parameterName := range parameters {
+					p := v1alpha1.HelmParameter{Name: parameterName, Value: newImage.GetFullNameWithoutTag(), ForceString: true}
+					mergeParams = append(mergeParams, p)
+				}
+			} else {
+				p := v1alpha1.HelmParameter{Name: hpImageName, Value: newImage.GetFullNameWithoutTag(), ForceString: true}
+				mergeParams = append(mergeParams, p)
+			}
 		}
 		if hpImageTag != "" {
-			p := v1alpha1.HelmParameter{Name: hpImageTag, Value: newImage.GetTagWithDigest(), ForceString: true}
-			mergeParams = append(mergeParams, p)
+			// Here is the case value1,value2
+			if strings.Contains(hpImageTag, ",") {
+				var parameters = strings.Split(hpImageTag, ",")
+				for _, parameterName := range parameters {
+					p := v1alpha1.HelmParameter{Name: parameterName, Value: newImage.GetTagWithDigest(), ForceString: true}
+					mergeParams = append(mergeParams, p)
+				}
+			} else {
+				p := v1alpha1.HelmParameter{Name: hpImageTag, Value: newImage.GetTagWithDigest(), ForceString: true}
+				mergeParams = append(mergeParams, p)
+			}
 		}
 	}
 

pkg/argocd/argocd_test.go

@@ -1046,6 +1046,89 @@ func Test_SetHelmImage(t *testing.T) {
 		require.Error(t, err)
 	})
 
+	t.Run("Test set Helm image parameters when two paths are provided", func(t *testing.T) {
+		app := &v1alpha1.Application{
+			ObjectMeta: v1.ObjectMeta{
+				Name:      "test-app",
+				Namespace: "testns",
+				Annotations: map[string]string{
+					fmt.Sprintf(common.HelmParamImageNameAnnotation, "foobar"): "foobar.image.name,foobar2.image.name",
+					fmt.Sprintf(common.HelmParamImageTagAnnotation, "foobar"):  "foobar.image.tag, foobar2.image.tag",
+				},
+			},
+			Spec: v1alpha1.ApplicationSpec{
+				Source: &v1alpha1.ApplicationSource{
+					Helm: &v1alpha1.ApplicationSourceHelm{
+						Parameters: []v1alpha1.HelmParameter{
+							{
+								Name:  "image.tag",
+								Value: "1.0.0",
+							},
+							{
+								Name:  "image.name",
+								Value: "jannfis/dummy",
+							},
+						},
+					},
+				},
+			},
+			Status: v1alpha1.ApplicationStatus{
+				SourceType: v1alpha1.ApplicationSourceTypeHelm,
+				Summary: v1alpha1.ApplicationSummary{
+					Images: []string{
+						"jannfis/foobar:1.0.0",
+					},
+				},
+			},
+		}
+
+		img := image.NewFromIdentifier("foobar=jannfis/foobar:1.0.1")
+
+		err := SetHelmImage(app, img)
+		require.NoError(t, err)
+		require.NotNil(t, app.Spec.Source.Helm)
+		assert.Len(t, app.Spec.Source.Helm.Parameters, 6)
+
+		// Find first correct parameter
+		var tagParam v1alpha1.HelmParameter
+		for _, p := range app.Spec.Source.Helm.Parameters {
+			if p.Name == "foobar.image.tag" {
+				tagParam = p
+				break
+			}
+		}
+		assert.Equal(t, "1.0.1", tagParam.Value)
+
+		// Find second correct parameter
+		var tagParamTwo v1alpha1.HelmParameter
+		for _, p := range app.Spec.Source.Helm.Parameters {
+			if p.Name == "foobar.image.tag" {
+				tagParamTwo = p
+				break
+			}
+		}
+		assert.Equal(t, "1.0.1", tagParamTwo.Value)
+
+		// Find first correct parameter
+		var nameParam v1alpha1.HelmParameter
+		for _, p := range app.Spec.Source.Helm.Parameters {
+			if p.Name == "foobar.image.name" {
+				nameParam = p
+				break
+			}
+		}
+		assert.Equal(t, "jannfis/foobar", nameParam.Value)
+
+		// Find second correct parameter
+		var nameParamTwo v1alpha1.HelmParameter
+		for _, p := range app.Spec.Source.Helm.Parameters {
+			if p.Name == "foobar2.image.name" {
+				nameParamTwo = p
+				break
+			}
+		}
+		assert.Equal(t, "jannfis/foobar", nameParamTwo.Value)
+	})
 }
 
 func TestKubernetesClient(t *testing.T) {