Skip to content

Commit 63e9dfd

Browse files
committedNov 11, 2024·
fix: disable local windows signing for forks PR
Resolves #2545
1 parent 3ccc864 commit 63e9dfd

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed
 

‎.github/workflows/build.yml

+2
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,8 @@ jobs:
286286
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
287287
WIN_CERT_PASSWORD: ${{ secrets.INSTALLER_CERT_WINDOWS_PASSWORD }}
288288
WIN_CERT_CONTAINER_NAME: ${{ secrets.INSTALLER_CERT_WINDOWS_CONTAINER }}
289+
WIN_SIGNING_ENABLED: ${{ !github.event.pull_request.head.repo.fork }}
290+
289291
strategy:
290292
matrix:
291293
config: ${{ fromJson(needs.select-targets.outputs.build-matrix) }}

‎electron-app/scripts/windowsCustomSign.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
const childProcess = require('child_process');
22

33
exports.default = async function (configuration) {
4-
if (!process.env.GITHUB_ACTIONS) {
4+
if (
5+
!process.env.GITHUB_ACTIONS ||
6+
process.env.WIN_SIGNING_ENABLED !== 'true'
7+
) {
58
return;
69
}
710

0 commit comments

Comments
 (0)
Please sign in to comment.