Skip to content

Commit 3c5c014

Browse files
author
Akos Kitta
committed
fix: let the upload run when no board is selected
IDE2 must not disable the upload from the UI when no board is selected. Otherwise, IDE2 does not receive the `no FQBN` error from the CLI and cannot cannot suggest selecting a board via the `Tools` > `Board` menu. Closes #1714 Signed-off-by: Akos Kitta <[email protected]>
1 parent aa9b10d commit 3c5c014

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

arduino-ide-extension/src/browser/contributions/user-fields.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ export class UserFields extends Contribution {
7474
async checkUserFieldsDialog(forceOpen = false): Promise<boolean> {
7575
const key = this.selectedFqbnAddress();
7676
if (!key) {
77-
return false;
77+
// Let the upload continue without an FQBN and the CLI fail instead of disabling the upload from IDE.
78+
// https://github.com/arduino/arduino-ide/issues/1714
79+
return true;
7880
}
7981
/*
8082
If the board requires to be configured with user fields, we want

0 commit comments

Comments
 (0)