Skip to content

Commit d68544e

Browse files
authored
If installer can't run post_install do not give up (#912)
* Changed core install message * Removed useless condition (letfover) * Convert errors running post_install into warnings
1 parent e3c2f6f commit d68544e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

commands/core/install.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,13 @@ func installPlatform(pm *packagemanager.PackageManager,
142142
// Perform post install
143143
if !skipPostInstall {
144144
log.Info("Running post_install script")
145-
taskCB(&rpc.TaskProgress{Message: "Configuring platform (post_install run)"})
145+
taskCB(&rpc.TaskProgress{Message: "Configuring platform"})
146146
if err := pm.RunPostInstallScript(platformRelease); err != nil {
147-
return errors.Errorf("running post install: %s", err)
147+
taskCB(&rpc.TaskProgress{Message: fmt.Sprintf("WARNING: cannot run post install: %s", err)})
148148
}
149-
} else if skipPostInstall {
149+
} else {
150150
log.Info("Skipping platform configuration (post_install run).")
151-
taskCB(&rpc.TaskProgress{Message: "Skipping platform configuration (post_install run)"})
151+
taskCB(&rpc.TaskProgress{Message: "Skipping platform configuration"})
152152
}
153153

154154
log.Info("Platform installed")

0 commit comments

Comments
 (0)