Skip to content

Commit 740a14e

Browse files
author
Federico Fissore
committed
UploadFactory: removed duplication
1 parent 0b8e792 commit 740a14e

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

Diff for: arduino-core/src/processing/app/debug/Compiler.java

+5-8
Original file line numberDiff line numberDiff line change
@@ -135,15 +135,12 @@ static public Uploader getUploaderByPreferences(boolean noUploadPort) {
135135
TargetPlatform target = BaseNoGui.getTargetPlatform();
136136
String board = PreferencesData.get("board");
137137

138-
if (noUploadPort)
139-
{
140-
return new UploaderFactory().newUploader(target.getBoards().get(board), null, noUploadPort);
141-
}
142-
else
143-
{
144-
BoardPort boardPort = BaseNoGui.getDiscoveryManager().find(PreferencesData.get("serial.port"));
145-
return new UploaderFactory().newUploader(target.getBoards().get(board), boardPort, noUploadPort);
138+
BoardPort boardPort = null;
139+
if (!noUploadPort) {
140+
boardPort = BaseNoGui.getDiscoveryManager().find(PreferencesData.get("serial.port"));
146141
}
142+
143+
return new UploaderFactory().newUploader(target.getBoards().get(board), boardPort, noUploadPort);
147144
}
148145

149146
static public boolean upload(SketchData data, Uploader uploader, String buildPath, String suggestedClassName, boolean usingProgrammer, boolean noUploadPort, List<String> warningsAccumulator) throws Exception {

0 commit comments

Comments
 (0)