Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attributes macros #339

Merged
merged 8 commits into from
Dec 1, 2022
Merged

Remove attributes macros #339

merged 8 commits into from
Dec 1, 2022

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Oct 21, 2022

This will partially fix #315 . As discussed we can just renema the macros with some more specialized name, but i decided to remove them because in my opinion this will make code more readable.

/cc @alranel

@pennam pennam requested review from aentinger and facchinm October 21, 2022 11:11
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 21, 2022
@pennam
Copy link
Collaborator Author

pennam commented Oct 21, 2022

Need to fix the failing test. Alarm set for monday morning 🕙

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Oct 24, 2022
@aentinger aentinger changed the title Remove attiributes macros Remove attributes macros Oct 27, 2022
@pennam pennam requested a review from mirkokurt November 16, 2022 07:36
@pennam
Copy link
Collaborator Author

pennam commented Dec 1, 2022

rebasing on master and dropping:

c2e261b

c2ee68b

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Memory usage change @ 7d5221c

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect ❔ -656 - +2 -0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 💚 -536 - 0 -0.03 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 💚 -736 - 0 -0.09 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 💚 -632 - 0 -0.24 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 💚 -568 - 0 -0.22 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 💚 -560 - 0 -0.21 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 💚 -504 - -288 -0.19 - -0.11 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -632 - 0 -0.24 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 💚 -632 - 0 -0.24 - 0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 💚 -1164 - -732 -0.09 - -0.06 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 💚 -636 - -384 -0.06 - -0.04 💚 -92 - -32 -0.11 - -0.04
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect -656 -0.0 0 0.0 -344 -0.0 0 0.0 -388 -0.0 0 0.0 2 0.0 0 0.0 2 0.0 0 0.0
arduino:mbed_nicla:nicla_vision -536 -0.03 0 0.0 -352 -0.02 0 0.0 -352 -0.02 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 -736 -0.09 0 0.0 -416 -0.05 0 0.0 -480 -0.06 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 -632 -0.24 0 0.0 -376 -0.14 0 0.0 -416 -0.16 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 -568 -0.22 0 0.0 -304 -0.12 0 0.0 -352 -0.13 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 -560 -0.21 0 0.0 -312 -0.12 0 0.0 -352 -0.13 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 -504 -0.19 0 0.0 -288 -0.11 0 0.0 -376 -0.14 0 0.0
arduino:samd:mkrwifi1010 -632 -0.24 0 0.0 -368 -0.14 0 0.0 -416 -0.16 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot -632 -0.24 0 0.0 -368 -0.14 0 0.0 -416 -0.16 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 -1164 -0.09 0 0.0 -732 -0.06 0 0.0 -808 -0.06 0 0.0
esp8266:esp8266:huzzah -636 -0.06 -92 -0.11 -384 -0.04 -32 -0.04 -432 -0.04 -32 -0.04
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,-656,-0.0,0,0.0,-344,-0.0,0,0.0,-388,-0.0,0,0.0,2,0.0,0,0.0,2,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,-536,-0.03,0,0.0,-352,-0.02,0,0.0,-352,-0.02,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,-736,-0.09,0,0.0,-416,-0.05,0,0.0,-480,-0.06,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkr1000,-632,-0.24,0,0.0,-376,-0.14,0,0.0,-416,-0.16,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,-568,-0.22,0,0.0,-304,-0.12,0,0.0,-352,-0.13,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,-560,-0.21,0,0.0,-312,-0.12,0,0.0,-352,-0.13,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,-504,-0.19,0,0.0,-288,-0.11,0,0.0,-376,-0.14,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,-632,-0.24,0,0.0,-368,-0.14,0,0.0,-416,-0.16,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,-632,-0.24,0,0.0,-368,-0.14,0,0.0,-416,-0.16,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,-1164,-0.09,0,0.0,-732,-0.06,0,0.0,-808,-0.06,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,-636,-0.06,-92,-0.11,-384,-0.04,-32,-0.04,-432,-0.04,-32,-0.04,,,,,,,,

@pennam pennam merged commit 27c05bc into arduino-libraries:master Dec 1, 2022
@pennam pennam deleted the attributes-fix branch May 17, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkokurt mirkokurt mirkokurt approved these changes

@aentinger aentinger Awaiting requested review from aentinger

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid creating constants and macros in the global namespace
3 participants
@pennam @mirkokurt @per1234