Web Api template attempts to retrieve an invalid KeyVault secrent-name

[fgheysels]

The Arcus Web API template defines that the AppInsights connection-string must be retrieved from KeyVault, and suggests that the secret that contains this connection-string is named APPLICATIONINSIGHTS_CONNECTION_STRING.

#if Serilog_AppInsights
        #warning Make sure that the Azure Application Insights connection string key is available as a secret.
        private const string ApplicationInsightsConnectionStringKeyName = "APPLICATIONINSIGHTS_CONNECTION_STRING";
        
#endif

However the underscore _ is a character that is not allowed in KeyVault secret-names.
The template must be modified in such a way that we either suggest another secret-name or that the mutateSecretName parameter is specified in the code that adds KeyVault as a secretprovider.

[stijnmoreels]

There are multiple providers defined, so we don't force people to use key vault. I even believe that by the name, we kinda suggest this to be an environment variable.
Happy to change this setup, of course. A good one for a first-time contributor.

[fgheysels]

If it's retrieved from KeyVault, this won't work as KeyVault doesn't allow underscores in its secret-name.
Since a KeyVault secretprovider is added via the template , I suggest that we define the mutate-secretname parameter ?

[stijnmoreels]

If it's retrieved from KeyVault, this won't work as KeyVault doesn't allow underscores in its secret-name. Since a KeyVault secretprovider is added via the template , I suggest that we define the mutate-secretname parameter ?

Yes, we could do that. Agreed. 👍