chore: remove deprecated secret store functionality (#426)

* chore: remove deprecated secret store functionality

* pr-fix: correct grouped secret store unit tests

* pr-fix: add additional test assertions on get interface provider

Author: stijnmoreels

src/Arcus.Security.Core/Caching/Configuration/CacheConfiguration.cs

@@ -8,14 +8,6 @@ namespace Arcus.Security.Core.Caching.Configuration
     /// </summary>
     public class CacheConfiguration : ICacheConfiguration
     {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="CacheConfiguration"/> class with default cache entry of 5 minutes.
-        /// </summary>
-        [Obsolete ("Use the " + nameof(Default) + " static property to retrieve a default caching configuration instance")]
-        public CacheConfiguration() : this(TimeSpan.FromMinutes(5))
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of the <see cref="CacheConfiguration"/> class.
         /// </summary>

src/Arcus.Security.Core/SecretStoreBuilder.cs

@@ -38,10 +38,6 @@ public SecretStoreBuilder(IServiceCollection services)
         /// <summary>
         /// Gets the available secret sources currently registered to be included in the resulting root secret store.
         /// </summary>
-        /// <remarks>
-        ///     The series of secret stores is directly publicly available including the operations so future (consumer) extensions can easily low-level manipulate this series during build-up.
-        ///     Though, for almost all use-cases, the <see cref="AddProvider(ISecretProvider,Func{string,string})"/> and the <see cref="AddProvider(Func{IServiceProvider,ISecretProvider},Func{string,string})"/> should be sufficient.
-        /// </remarks>
         public IList<SecretStoreSource> SecretStoreSources { get; } = new List<SecretStoreSource>();
 
         /// <summary>
@@ -63,17 +59,15 @@ public SecretStoreBuilder(IServiceCollection services)
         /// Adds an <see cref="ISecretProvider"/> implementation to the secret store of the application.
         /// </summary>
         /// <param name="secretProvider">The provider which secrets are added to the secret store.</param>
-        /// <param name="mutateSecretName">The optional function to mutate the secret name before looking it up.</param>
         /// <returns>
         ///     The extended secret store with the given <paramref name="secretProvider"/>.
         /// </returns>
         /// <exception cref="ArgumentNullException">Thrown when the <paramref name="secretProvider"/> is <c>null</c>.</exception>
-        [Obsolete("Consider using the " + nameof(AddProvider) + " overload with the " + nameof(SecretProviderOptions.MutateSecretName) + " instead")]
-        public SecretStoreBuilder AddProvider(ISecretProvider secretProvider, Func<string, string> mutateSecretName = null)
+        public SecretStoreBuilder AddProvider(ISecretProvider secretProvider)
         {
             Guard.NotNull(secretProvider, nameof(secretProvider), "Requires a secret provider to add to the secret store");
 
-            return AddProvider(secretProvider, options => options.MutateSecretName = mutateSecretName);
+            return AddProvider(secretProvider, configureOptions: null);
         }
 
         /// <summary>
@@ -111,19 +105,15 @@ public SecretStoreBuilder AddProvider(
         /// Adds an <see cref="ISecretProvider"/> implementation to the secret store of the application.
         /// </summary>
         /// <param name="createSecretProvider">The function to create a provider which secrets are added to the secret store.</param>
-        /// <param name="mutateSecretName">The optional function to mutate the secret name before looking it up.</param>
         /// <returns>
         ///     The extended secret store with the given <paramref name="createSecretProvider"/> as lazy initialization.
         /// </returns>
         /// <exception cref="ArgumentNullException">Thrown when the <paramref name="createSecretProvider"/> is <c>null</c>.</exception>
-        [Obsolete("Consider using the " + nameof(AddProvider) + " overload with the " + nameof(SecretProviderOptions.MutateSecretName) + " instead")]
-        public SecretStoreBuilder AddProvider(
-            Func<IServiceProvider, ISecretProvider> createSecretProvider,
-            Func<string, string> mutateSecretName = null)
+        public SecretStoreBuilder AddProvider(Func<IServiceProvider, ISecretProvider> createSecretProvider)
         {
             Guard.NotNull(createSecretProvider, nameof(createSecretProvider), "Requires a function to create a secret provider to add to the secret store");
 
-            return AddProvider(createSecretProvider, options => options.MutateSecretName = mutateSecretName);
+            return AddProvider(createSecretProvider, configureOptions: null);
         }
 
         /// <summary>

src/Arcus.Security.Core/SecretStoreSource.cs

@@ -17,20 +17,6 @@ public class SecretStoreSource
 
         private ISecretProvider _secretProvider;
 
-        /// <summary>
-        /// Initializes a new instance of the <see cref="SecretStoreSource"/> class.
-        /// </summary>
-        /// <param name="createSecretProvider">The function to create a secret provider to add to the secret store.</param>
-        /// <param name="mutateSecretName">The optional mutation function to transform secret names.</param>
-        /// <exception cref="ArgumentNullException">Thrown when the <paramref name="createSecretProvider"/> is <c>null</c>.</exception>
-        [Obsolete("Use the other constructor overload with the " + nameof(SecretProviderOptions) + " instead")]
-        public SecretStoreSource(
-            Func<IServiceProvider, ISecretProvider> createSecretProvider, 
-            Func<string, string> mutateSecretName = null) 
-            : this(createSecretProvider, new SecretProviderOptions { MutateSecretName = mutateSecretName })
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of the <see cref="SecretStoreSource"/> class.
         /// </summary>
@@ -48,18 +34,6 @@ public SecretStoreSource(
             Options = options ?? new SecretProviderOptions();
         }
 
-        /// <summary>
-        /// Initializes a new instance of the <see cref="SecretStoreSource"/> class.
-        /// </summary>
-        /// <param name="secretProvider">The secret provider to add to the secret store.</param>
-        /// <param name="mutateSecretName">The optional mutation function to transform secret names.</param>
-        /// <exception cref="ArgumentNullException">Thrown when the <paramref name="secretProvider"/> is <c>null</c>.</exception>
-        [Obsolete("Use the other constructor overload with the " + nameof(SecretProviderOptions) + " instead")]
-        public SecretStoreSource(ISecretProvider secretProvider, Func<string, string> mutateSecretName = null)
-            : this(secretProvider, new SecretProviderOptions { MutateSecretName = mutateSecretName})
-        {
-        }
-
         /// <summary>
         /// Initializes a new instance of the <see cref="SecretStoreSource"/> class.
         /// </summary>
@@ -78,10 +52,6 @@ public SecretStoreSource(ISecretProvider secretProvider, SecretProviderOptions o
         /// Gets the provider for this secret store.
         /// </summary>
         /// <exception cref="InvalidOperationException">Thrown when the <see cref="EnsureSecretProviderCreated"/> was not yet called after creating a lazy secret provider source.</exception>
-        /// <remarks>
-        ///     When this secret provider source registration was initialized with the <see cref="SecretStoreSource(Func{IServiceProvider,ISecretProvider},Func{string,string})"/>
-        ///     than the <see cref="EnsureSecretProviderCreated"/> method has to be called first to initialized the lazy created <see cref="ISecretProvider"/>.
-        /// </remarks>
         public ISecretProvider SecretProvider
         {
             get
@@ -100,28 +70,16 @@ public ISecretProvider SecretProvider
         /// <summary>
         /// Gets the versioned provider for this secret provider registration, if the <see cref="SecretProvider"/> is a <see cref="IVersionedSecretProvider"/> implementation.
         /// </summary>
-        /// <remarks>
-        ///     When this secret provider source registration was initialized with the <see cref="SecretStoreSource(Func{IServiceProvider,ISecretProvider},Func{string,string})"/>
-        ///     than the <see cref="EnsureSecretProviderCreated"/> method has to be called first to initialized the lazy created <see cref="IVersionedSecretProvider"/>.
-        /// </remarks>
         public IVersionedSecretProvider VersionedSecretProvider { get; private set; }
 
         /// <summary>
         /// Gets the synchronous variant of this secret provider registration, if the <see cref="SecretProvider"/> is a <see cref="ISyncSecretProvider"/> implementation.
         /// </summary>
-        /// <remarks>
-        ///     When this secret provider source registration was initialized with the <see cref="SecretStoreSource(Func{IServiceProvider,ISecretProvider},Func{string,string})"/>
-        ///     than the <see cref="EnsureSecretProviderCreated"/> method has to be called first to initialized the lazy created <see cref="ISyncSecretProvider"/>.
-        /// </remarks>
         public ISyncSecretProvider SyncSecretProvider { get; private set; }
 
         /// <summary>
         /// Gets the cached provider for this secret provider registration, if the <see cref="SecretProvider"/> is a <see cref="ICachedSecretProvider"/> implementation.
         /// </summary>
-        /// <remarks>
-        ///     When this secret provider source registration was initialized with the <see cref="SecretStoreSource(Func{IServiceProvider,ISecretProvider},Func{string,string})"/>
-        ///     than the <see cref="EnsureSecretProviderCreated"/> method has to be called first to initialized the lazy created <see cref="ICachedSecretProvider"/>.
-        /// </remarks>
         public ICachedSecretProvider CachedSecretProvider { get; private set; }
 
         /// <summary>