Skip to content

Commit c23d1f7

Browse files
committed
rust: document bindgen 0.71.0 regression
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header" issue which appeared in 0.69.0 first [2] and was fixed in 0.69.1. It has been fixed again in 0.71.1 [3]. Thus document it so that, when we upgrade the minimum past 0.69.0 in the future, we do not forget that we cannot remove the workaround until we arrive at 0.71.1 at least. Link: rust-lang/rust-bindgen#3039 [1] Link: rust-lang/rust-bindgen#2677 [2] Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3] Reviewed-by: Fiona Behrens <[email protected]> Reviewed-by: Alice Ryhl <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
1 parent 0c5928d commit c23d1f7

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

init/Kconfig

+4-2
Original file line numberDiff line numberDiff line change
@@ -1989,8 +1989,10 @@ config BINDGEN_VERSION_TEXT
19891989
string
19901990
depends on RUST
19911991
# The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
1992-
# (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
1993-
# the minimum version is upgraded past that (0.69.1 already fixed the issue).
1992+
# (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
1993+
# (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed
1994+
# when the minimum version is upgraded past the latter (0.69.1 and 0.71.1
1995+
# both fixed the issue).
19941996
default "$(shell,$(BINDGEN) --version workaround-for-0.69.0 2>/dev/null)"
19951997

19961998
#

scripts/rust_is_available.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,10 @@ fi
123123
# Non-stable and distributions' versions may have a version suffix, e.g. `-dev`.
124124
#
125125
# The dummy parameter `workaround-for-0.69.0` is required to support 0.69.0
126-
# (https://github.com/rust-lang/rust-bindgen/pull/2678). It can be removed when
127-
# the minimum version is upgraded past that (0.69.1 already fixed the issue).
126+
# (https://github.com/rust-lang/rust-bindgen/pull/2678) and 0.71.0
127+
# (https://github.com/rust-lang/rust-bindgen/pull/3040). It can be removed when
128+
# the minimum version is upgraded past the latter (0.69.1 and 0.71.1 both fixed
129+
# the issue).
128130
rust_bindings_generator_output=$( \
129131
LC_ALL=C "$BINDGEN" --version workaround-for-0.69.0 2>/dev/null
130132
) || rust_bindings_generator_code=$?

0 commit comments

Comments
 (0)