Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JGit garbage collection is slow #108

Open
Phillipus opened this issue Oct 3, 2019 · 3 comments
Open

JGit garbage collection is slow #108

Phillipus opened this issue Oct 3, 2019 · 3 comments

Comments

@Phillipus
Copy link
Member

More of a heads up than bug report.

I hit "Refresh" (Pull) and the dialog was stuck for a long time. A debug trace showed that JGit was garbage collecting. Very slowly. I let it do its thing and it got there in the end. This was with JGit 4.11 and 5.3.0.

@janesser
Copy link

@Phillipus hi, "same procedure as every year" i tend to code a little. On the one hand getting a confined eclipse snap to work, which is no matter for here. Let me say, that i saw a lot good from you in the eclipse community.

On the other hand, i've been trying to poc my thoughts about getting around of jgit/egit, which have a lot of impact on my day2day. Especially because of slowness, see the other thread earlier: archimatetool/archi-modelrepository-plugin2#11 (comment)

How has your idea evolved in the meanwhile - is coArchi2 the (only) way to go ? IIRC git would not be on the shortlist of sharing platforms with some mixed implications.

My simple (maybe naive) proposal was started here: eclipse-egit/egit#47
Basically wrapping around git-cli which is most optimized.

There is nothing but trying here:
janesser@347874f
janesser@58c1a44

Your reply would be very welcome. Cheers.

@Phillipus
Copy link
Member Author

Phillipus commented Dec 21, 2024

Hi, this issue is about the possibility of JGit being slow when garbage collecting. Let's keep it to that.

However:

  • coArchi 2 will be continued and I will not be adding any more to coArchi 1 - see Why coArchi 2?
  • coArchi 1 is slow not because it uses JGit but because of all the thousands of XML files it creates.
  • We don't use EGit at all, only JGit. EGit is an Eclipse UI plug-in that uses JGit as the backend. We will only use JGit in coArchi 2.

@janesser
Copy link

@Phillipus cool. i guess with a smaller set of files jgit gc will be less greedy.
let me know if i there is anything on coArchi 2 where a little contribution would help.

sorry for being the stubborn one;
anyway i will continue my kata attempting to show that a non-java integration of git deserves at least a little more consideration.

p.s. just looking through credential handling in coarchi and how the git-cli offers helpers. that is a descent puzzle to keep me busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants