Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CKEditor 4 #10828

Open
bferguso opened this issue Apr 24, 2024 · 6 comments
Open

Replace CKEditor 4 #10828

bferguso opened this issue Apr 24, 2024 · 6 comments
Labels
Type: Bug Something isn't working Type: Dependencies

Comments

@bferguso
Copy link
Contributor

CKEditor 4 is end of life as of June 2023: https://ckeditor.com/ckeditor-4/. We should either upgrade to CKEditor 5 of look at alternatives.

@chiatt chiatt added this to pipeline Apr 24, 2024
@chiatt chiatt moved this to 📋 Backlog in pipeline Jun 4, 2024
@apeters apeters added Type: Bug Something isn't working Type: Dependencies labels Jun 11, 2024
@apeters
Copy link
Member

apeters commented Jun 11, 2024

The latest ckeditor (v 4.23 and greater) now requires a license (Arches is currently pegged to full/4.24.x). This is throwing an error in current implementations of Arches. They offer a free license to open source software projects. We should either get a license from them or find and alternative to ckeditor.

example error I'm seeing in the client

ckeditor.js:370 [CKEDITOR]: The license key is missing or invalid.

If you suddenly started to see this message, this may mean you accidentally updated CKEditor 4 
to the LTS version (4.23.0 and above). This version of the editor is under commercial terms 
and requires acquiring an "Extended Support Model" contract - https://ckeditor.com/ckeditor-4-support/

@apeters
Copy link
Member

apeters commented Jun 11, 2024

@chiatt and @chrabyrd ☝️ I notice that we just updated the version of ckeditor in package.json

@chrabyrd
Copy link
Contributor

@chiatt and @chrabyrd ☝️ I notice that we just updated the version of ckeditor in package.json

@apeters Yep! It was part of the move to npm, and it was updated to the most recent version that doesn't require a license. This was to resolve a few security issues the previous version was throwing when npm audit was run.

I do not have a strong opinion about either obtaining a license from the CKEditor org or moving to a different package, though if we choose to move to a different package Quill looks like a good candidate.

@chrabyrd
Copy link
Contributor

Doing some more thinking on this and I believe we can probably get away with keeping CKEditor4 past EOL, with the argument that essentially our KOJS components have entered maintenance-only mode. But we should definitely find a modern replacement for integrating into Vue

@apeters
Copy link
Member

apeters commented Jun 12, 2024

@apeters Yep! It was part of the move to npm, and it was updated to the most recent version that doesn't require a license.

@chrabyrd it does seem to require a license though, hence the error message I saw in the console.

@chrabyrd
Copy link
Contributor

@apeters ahh you're right, it's been reverted in #11040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Dependencies
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants