Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Frontend) Import Graph doesn't validate concept collections or Related Resource Models against what's in database #10775

Open
whatisgalen opened this issue Apr 15, 2024 · 0 comments
Labels

Comments

@whatisgalen
Copy link
Member

whatisgalen commented Apr 15, 2024

When importing a graph whose concept nodes reference a specific collection (or whose resource-instance nodes reference a specific Resource Model), there is no warning or error during import of any referenced collections or Resource Models not present in the project database. It would be annoying if this blocked import altogether, but at a minimum it should:

  1. Issue a warning of which nodes reference unavailable collections, (same goes for Resource-Instance Nodes whose referenced Resource Model is not available)
  2. Ensure that the Resource Model is set to Unpublished at start

Ideally the Graph Designer should throw a GraphValidationError if a user tries to publish a Resource Model with nodes pointing to missing collections so as to prevent creating resourceinstance data against it (since missing collections breaks the card UI for the offending nodegroups in the Resource Editor)

Note: this was tested as of dev/7.6.x at time of writing (4/15/24)

@chiatt chiatt added this to pipeline Apr 15, 2024
@whatisgalen whatisgalen changed the title (Frontend) Import Graph doesn't validate node concept collections against what's in database (Frontend) Import Graph doesn't validate concept collections or Related Resource Models against what's in database Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant