Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arches has no way of programmatically enforcing test coverage #10738

Closed
chrabyrd opened this issue Apr 3, 2024 · 1 comment · Fixed by #10739
Closed

Arches has no way of programmatically enforcing test coverage #10738

chrabyrd opened this issue Apr 3, 2024 · 1 comment · Fixed by #10739
Assignees
@chrabyrd

Comments

@chrabyrd
Copy link
Contributor

chrabyrd commented Apr 3, 2024

No description provided.

@chrabyrd chrabyrd self-assigned this Apr 3, 2024
@chiatt chiatt added this to pipeline Apr 3, 2024
chrabyrd added a commit that referenced this issue Apr 3, 2024
@chrabyrd
adds test coverage github action #10738
074a3a1
@chrabyrd chrabyrd mentioned this issue Apr 3, 2024
Merged
3 tasks
chrabyrd added a commit that referenced this issue Apr 3, 2024
@chrabyrd
re-add yarn build process #10738
8cb6996
chrabyrd added a commit that referenced this issue Apr 3, 2024
@chrabyrd
update 7.6.0.md #10738
dde3bbf
chrabyrd added a commit that referenced this issue Apr 3, 2024
@chrabyrd
nit #10738
91b1012
chrabyrd added a commit that referenced this issue Apr 3, 2024
@chrabyrd
nit #10738
88baaea
chrabyrd added a commit that referenced this issue Apr 3, 2024
@chrabyrd
nit #10738
7a51c0c
chrabyrd added a commit that referenced this issue Apr 3, 2024
@chrabyrd
nit #10738
fb94351
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In Progress in pipeline Apr 9, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Apr 17, 2024
@jacobtylerwalls jacobtylerwalls linked a pull request Apr 17, 2024 that will close this issue
adds test coverage github action #10738 #10739
Merged
3 tasks
chrabyrd added a commit that referenced this issue Apr 18, 2024
@chrabyrd
merge #10738
0e79799
chrabyrd added a commit that referenced this issue Apr 18, 2024
@chrabyrd
nit #10738
2bfc60f
chrabyrd added a commit that referenced this issue Apr 18, 2024
@chrabyrd
deletes coverage.json #10738
e900e12
chrabyrd added a commit that referenced this issue Apr 18, 2024
@chrabyrd
nit #10738
195b210
chrabyrd added a commit that referenced this issue Apr 18, 2024
@chrabyrd
adds check on PR approval to ensure feature branch is up-to-date with…
61691d7 
… current branch #10738
chrabyrd added a commit that referenced this issue Apr 19, 2024
@chrabyrd
reverts check for latest version of target branch -- opted to used st…
0f9bc4d 
…atus check instead #10738
apeters added a commit that referenced this issue Apr 23, 2024
@apeters
add test commit for #10738
47bc89a
@apeters apeters mentioned this issue Apr 23, 2024
Closed
chrabyrd added a commit that referenced this issue Apr 24, 2024
@chrabyrd
nit #10738
3431382
chrabyrd added a commit that referenced this issue Apr 24, 2024
@chrabyrd
nit #10738
0acb7bf
chrabyrd added a commit that referenced this issue Apr 24, 2024
@chrabyrd
merge #10738
231e4ed
apeters added a commit that referenced this issue Apr 25, 2024
@apeters
test commit for #10738
88043bd
apeters added a commit that referenced this issue Apr 25, 2024
@apeters
Merge pull request #10739 from archesproject/10738-cbyrd-add-github-a…
6816d8a 
…ction-test-coverage-enforcement

adds test coverage github action #10738
@chrabyrd
Copy link
Contributor Author

resolved in #10739

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Apr 25, 2024
jacobtylerwalls added a commit that referenced this issue May 2, 2024
@jacobtylerwalls
Measure coverage on untested files re #10738
011f9be 
Without the `--source` option, coverage.py doesn't discover python
files that aren't exercised in your tests. For instance, the entire etl_modules
directory was untested, and wasn't included in the coverage denominator.
(Also, that directory needed an __init__.py to be discovered.)

https://coverage.readthedocs.io/en/7.5.0/source.html
chrabyrd added a commit that referenced this issue May 2, 2024
@chrabyrd
Merge pull request #10859 from archesproject/jtw/add-uncovered-files-…
bf0bc15 
…to-denominator

Measure coverage on untested files re #10738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrabyrd chrabyrd

Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds test coverage github action #10738 archesproject/arches
1 participant
@chrabyrd