Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow history API returns improper error code for updating completed workflow #10710

Closed
jacobtylerwalls opened this issue Mar 25, 2024 · 0 comments · Fixed by #10711
Closed
Assignees

Comments

@jacobtylerwalls
Copy link
Member

400 (Bad Request) would be more accurate than 401 (Not Authorized) for attempting to update a completed workflow.

Suggesting to target 7.6, as this isn't severe enough to have blocked a release.

if not created:
if history.completed:
return JSONErrorResponse(
_("Request Failed"),
_("Workflow already completed"),
status=401,
)

@jacobtylerwalls jacobtylerwalls self-assigned this Mar 25, 2024
@chiatt chiatt added this to pipeline Mar 25, 2024
jacobtylerwalls added a commit that referenced this issue Mar 25, 2024
@jacobtylerwalls jacobtylerwalls moved this to 👀 In Review in pipeline Mar 25, 2024
@jacobtylerwalls jacobtylerwalls linked a pull request Mar 25, 2024 that will close this issue
6 tasks
apeters added a commit that referenced this issue Apr 16, 2024
Improve test isolation and reduce test verbosity #7186 #10710
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant