Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controlled-lists] Implement adjusting item parentage #10604

Closed
jacobtylerwalls opened this issue Feb 9, 2024 · 0 comments · Fixed by #10569
Closed

[controlled-lists] Implement adjusting item parentage #10604

jacobtylerwalls opened this issue Feb 9, 2024 · 0 comments · Fixed by #10569
Assignees
@jacobtylerwalls

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Feb 9, 2024 •
edited
Loading

The front-end design is in flux, but regardless, we will want some back-end validation against creating a reference cycle (e.g. child is parent of itself, or similar at varying depths).

This happened during development and caused recursion errors in the python views.

Move new serialized list inside transaction?

Edit: this should be handled as part of adjusting parentage
@chiatt chiatt added this to pipeline Feb 9, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in Controlled List Manager Apr 3, 2024
@jacobtylerwalls jacobtylerwalls self-assigned this Apr 3, 2024
@jacobtylerwalls jacobtylerwalls changed the title [controlled-lists] Harden against circular references among list items [controlled-lists] Implement adjusting item parentage Apr 3, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 🔖 Ready in Controlled List Manager Apr 3, 2024
@jacobtylerwalls jacobtylerwalls moved this to 🔖 Ready in pipeline Apr 5, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In Progress in pipeline Apr 9, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in Controlled List Manager Apr 9, 2024
jacobtylerwalls added a commit that referenced this issue Apr 9, 2024
@jacobtylerwalls
Stub out move item modal #10604
d036645
@jacobtylerwalls jacobtylerwalls linked a pull request Apr 9, 2024 that will close this issue
Implement controlled list manager and reference datatype #10541 #10569
Merged
10 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in Controlled List Manager Apr 16, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Apr 16, 2024
jacobtylerwalls added a commit that referenced this issue Apr 16, 2024
@jacobtylerwalls
Add protection against recursive cycles #10604
3c36dae
jacobtylerwalls added a commit that referenced this issue Apr 16, 2024
@jacobtylerwalls
Allow backend to recalculate sortorder re #10604
18d8988
jacobtylerwalls added a commit that referenced this issue Apr 16, 2024
@jacobtylerwalls
Move "abandon move" button to banner #10604
06f52f5
jacobtylerwalls added a commit that referenced this issue Apr 16, 2024
@jacobtylerwalls
Update tests, extend reordering behavior re #10604
8ff0f50
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Stub out move item modal #10604
105bec5
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Add protection against recursive cycles #10604
34aa056
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Allow backend to recalculate sortorder re #10604
d752fc1
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Move "abandon move" button to banner #10604
09cb08b
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Update tests, extend reordering behavior re #10604
ff8c0b7
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Stub out move item modal #10604
6d43c27
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Add protection against recursive cycles #10604
da2dac8
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Allow backend to recalculate sortorder re #10604
9a2cdfb
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Move "abandon move" button to banner #10604
d597cd0
jacobtylerwalls added a commit that referenced this issue Apr 25, 2024
@jacobtylerwalls
Update tests, extend reordering behavior re #10604
d922b13
jacobtylerwalls added a commit that referenced this issue May 15, 2024
@jacobtylerwalls
Stub out move item modal #10604
5014e08
jacobtylerwalls added a commit that referenced this issue May 15, 2024
@jacobtylerwalls
Add protection against recursive cycles #10604
47f50bc
jacobtylerwalls added a commit that referenced this issue May 15, 2024
@jacobtylerwalls
Allow backend to recalculate sortorder re #10604
c91b917
jacobtylerwalls added a commit that referenced this issue May 15, 2024
@jacobtylerwalls
Move "abandon move" button to banner #10604
35c99ad
jacobtylerwalls added a commit that referenced this issue May 15, 2024
@jacobtylerwalls
Update tests, extend reordering behavior re #10604
9922ce2
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Controlled List Manager Jul 2, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
Controlled List Manager
Status: ✅ Done
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement controlled list manager and reference datatype #10541 archesproject/arches
1 participant
@jacobtylerwalls