Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins can't be edited in the Django admin #10597

Closed
jacobtylerwalls opened this issue Feb 8, 2024 · 2 comments
Closed

Plugins can't be edited in the Django admin #10597

jacobtylerwalls opened this issue Feb 8, 2024 · 2 comments
Assignees
Labels

Comments

@jacobtylerwalls
Copy link
Member

After Plugin.name was localized in #10517, you can no longer use the Django admin to edit a plugin. The non-localized name will load in the form, and then saving the form throws "Enter a valid JSON" when saving the field.

Workaround is to hand-edit the name to look like localized JSON again.

Could block people from using the Django admin to set {"show": True} in the config field.

Version: 7.6 dev

@chiatt chiatt added this to pipeline Feb 8, 2024
@chiatt chiatt moved this to 🔖 Ready in pipeline Mar 11, 2024
@johnatawnclementawn
Copy link
Member

+1

@johnatawnclementawn
Copy link
Member

This appears to be related to #9794 - Somewhere in the line of converting back and forth between json and strings, the double quotes around the value are dropped when being supplied to the django admin. It could be related to how we're overriding _parse on both I18n_JSONFields & I18n_TextFields, made worse by upgrade to Django 4.2

@jacobtylerwalls jacobtylerwalls self-assigned this Jun 13, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In Progress in pipeline Jul 9, 2024
jacobtylerwalls added a commit that referenced this issue Jul 9, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Jul 9, 2024
chiatt pushed a commit that referenced this issue Jul 10, 2024
chiatt pushed a commit that referenced this issue Jul 10, 2024
@chiatt chiatt closed this as completed Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants