Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File URLs handled differently in file-widget and photo-gallery-card #10584

Closed
bferguso opened this issue Feb 7, 2024 · 0 comments · Fixed by #10585
Closed

File URLs handled differently in file-widget and photo-gallery-card #10584

bferguso opened this issue Feb 7, 2024 · 0 comments · Fixed by #10585
Labels
Type: Bug Something isn't working

Comments

@bferguso
Copy link
Contributor

bferguso commented Feb 7, 2024 •
edited
Loading

In viewmodels/file-widget.js, URLs are prefixed with the arches.urls.url_subpath if they do not begin with http[s]://. The views/components/cards/photo-gallery-card.js does not do that. The behaviour should be the same.

Suggesting that the behaviour of both is aligned and changed to prefix url with arches.urls.url_subpath only if:

  1. it doesn't start with http[s]:// and
  2. it doesn't start with arches.urls.url_subpath.
@bferguso bferguso added the Type: Bug Something isn't working label Feb 7, 2024
@chiatt chiatt added this to pipeline Feb 7, 2024
@bferguso bferguso mentioned this issue Feb 7, 2024
Merged
6 tasks
@jacobtylerwalls jacobtylerwalls linked a pull request Feb 7, 2024 that will close this issue
10584 - Make file URL formatting consistent #10585
Merged
6 tasks
@jacobtylerwalls jacobtylerwalls moved this to 👀 In Review in pipeline Feb 7, 2024
jacobtylerwalls added a commit that referenced this issue Feb 7, 2024
@jacobtylerwalls
nits re #10584
cb88d6d
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10584 - Make file URL formatting consistent archesproject/arches
2 participants
@bferguso @jacobtylerwalls