Skip to content

Commit 955508c

Browse files
nit re #10541, rewrite multi-line ternaries
1 parent baa0bcb commit 955508c

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed

arches/app/src/components/ControlledListManager/AddLabel.vue

+8-3
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,14 @@ const { $gettext } = useGettext();
2525
const slateBlue = "#2d3c4b"; // todo: import from theme somewhere
2626
2727
const buttonLabel = computed(() => {
28-
return props.type === "prefLabel"
29-
? $gettext("Add Preferred Label")
30-
: $gettext("Add Alternate Label");
28+
switch (props.type) {
29+
case "prefLabel":
30+
return $gettext("Add Preferred Label");
31+
case "altLabel":
32+
return $gettext("Add Alternate Label");
33+
default:
34+
throw new Error();
35+
}
3136
});
3237
</script>
3338

arches/app/src/components/ControlledListManager/ItemCharacteristic.vue

+2-3
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@ const onSave = () => {
5050
// eslint-disable-next-line vue/no-mutating-props
5151
props.item[props.field] = dirtyFormValue.value;
5252
53-
const saveFn = Object.hasOwn(props.item, "items")
54-
? postListToServer
55-
: postItemToServer;
53+
const isList = Object.hasOwn(props.item, "items");
54+
const saveFn = isList ? postListToServer : postItemToServer;
5655
saveFn(props.item, toast, $gettext);
5756
};
5857
const onCancel = () => {

arches/app/src/components/ControlledListManager/LabelRow.vue

+8-4
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,15 @@ const visible = ref(false);
1818
1919
const { $gettext } = useGettext();
2020
const header = computed(() => {
21-
return props.label.valuetype === "prefLabel"
22-
? $gettext("Edit Preferred Label")
23-
: $gettext("Edit Alternate Label");
21+
switch (props.label.valuetype) {
22+
case "prefLabel":
23+
return $gettext("Edit Preferred Label");
24+
case "altLabel":
25+
return $gettext("Edit Alternate Label");
26+
default:
27+
throw new Error();
28+
}
2429
});
25-
2630
</script>
2731

2832
<template>

0 commit comments

Comments
 (0)