Validates node config on graph save, #10552

Author: chiatt

arches/app/datatypes/base.py

@@ -462,3 +462,9 @@ def pre_structure_tile_data(self, tile, nodeid, **kwargs):
         Adds properties to a tile necessary for some clients, but not essential to the tile
         """
         pass
+
+    def validate_node(self, node):
+        """
+        Confirms that a node is properly configured to collect data
+        """
+        return {"success": True}

arches/app/datatypes/datatypes.py

@@ -2691,4 +2691,23 @@ def default_es_mapping(self):
                 },
             }
         }
-        return mapping
+        return mapping
+
+    def validate_node(self, node):
+        valid = False
+        message = ""
+        title = ""
+        try:
+            uuid.UUID(node.config["controlledList"])
+            valid = True
+        except TypeError:
+            message = _("A reference datatype node must be configured with a controlled list")
+            title = _("Invalid Node Configuration")
+            logger.error(message)
+
+        except Exception as e:
+            message = _("Ensure your node is propertly configured for the reference datatype")
+            title = _("Invalid Node Configuration")
+            logger.error(message)
+
+        return {"success": valid, "message": message, "title": title}

arches/app/models/graph.py

@@ -1675,6 +1675,13 @@ def _validate_node_name(self, node):
                     message = _('Duplicate node name: "{0}". All sibling node names must be unique.'.format(node.name))
                     raise GraphValidationError(message)
 
+    def _validate_node_config(self, node, datatype_factory):
+        datatype = datatype_factory.get_instance(node.datatype)
+        validation = datatype.validate_node(node)
+        if validation["success"] is False:
+            message = validation["message"]
+            raise GraphValidationError(message)
+
     def create_node_alias(self, node):
         """
         Assigns a unique, slugified version of a node's name as that node's alias.
@@ -1739,8 +1746,11 @@ def validate_fieldname(fieldname, fieldnames):
             return fieldname
 
         fieldnames = {}
+        datatype_factory = DataTypeFactory()
+
         for node_id, node in self.nodes.items():
             self._validate_node_name(node)
+            self._validate_node_config(node, datatype_factory)
             if node.exportable is True:
                 if node.fieldname is not None:
                     validated_fieldname = validate_fieldname(node.fieldname, fieldnames)