Setup linter and add basic rules (#403)

Add linter rules for imports

Author: nikita-vanyasin

.golangci.yaml

@@ -0,0 +1,52 @@
+---
+
+run:
+  issues-exit-code: 3
+  timeout: 30m
+  skip-dirs:
+    - vendor
+
+linters:
+  fast: false
+  enable-all: false
+  disable-all: false
+  presets:
+    - performance
+    - format
+    - complexity
+    - bugs
+    - unused
+  disable:
+    - staticcheck
+    - errcheck
+    - govet
+    - gosec
+    - ineffassign
+    - noctx
+    - contextcheck
+    - unparam
+    - scopelint
+    - exhaustive
+    - cyclop
+    - errorlint
+    - errchkjson
+    - nestif
+    - prealloc
+    - maligned
+    - funlen
+    - typecheck
+    - deadcode
+    - unused
+    - maintidx
+    - varcheck
+    - gocognit
+    - gofumpt
+    - gocyclo
+
+linters-settings:
+  gci:
+    sections:
+      - standard
+      - default
+      - prefix(github.com/arangodb)
+      - prefix(github.com/arangodb/go-driver)

.travis.yml

@@ -42,6 +42,7 @@ env:
 
 script:
   - |
-    if [ "$TRAVIS_PULL_REQUEST" != "false" ] || [ ! -z "$ALWAYS" ]; then 
+    if [ "$TRAVIS_PULL_REQUEST" != "false" ] || [ ! -z "$ALWAYS" ]; then
+      make linter
       make $TEST_SUITE TEST_RESOURCES="$HOME/resources/" VERBOSE=1;
     fi

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [master](https://github.com/arangodb/go-driver/tree/master) (N/A)
 - Fix `lastValue` field type
+- Setup Go-lang linter with minimal configuration 
 - Use Go 1.17.6
 
 ## [1.3.2](https://github.com/arangodb/go-driver/tree/v1.3.2) (2022-05-16)

Makefile

@@ -136,7 +136,7 @@ else
     DOCKER_V2_RUN_CMD := $(GOV2IMAGE) go test $(GOBUILDTAGSOPT) $(TESTOPTIONS) $(TESTVERBOSEOPTIONS) ./tests
 endif
 
-.PHONY: all build clean run-tests
+.PHONY: all build clean linter run-tests
 
 all: build
 
@@ -492,6 +492,8 @@ run-benchmarks-single-vpack-no-auth:
 
 .PHONY: tools
 tools:
+	@echo ">> Fetching golangci-lint linter"
+	@GOBIN=$(TMPDIR)/bin go install github.com/golangci/golangci-lint/cmd/[email protected]
 	@echo ">> Fetching goimports"
 	@go get -mod 'readonly' golang.org/x/tools/cmd/goimports
 	@echo ">> Fetching license check"
@@ -519,10 +521,7 @@ fmt-verify: license-verify
 
 .PHONY: linter
 linter: fmt
-	@golangci-lint run --no-config --issues-exit-code=1 --deadline=30m --disable-all \
-	                  $(foreach MODE,$(GOLANGCI_ENABLED),--enable $(MODE) ) \
-	                  --exclude-use-default=false \
-	                  $(SOURCES_PACKAGES)
+	$(TMPDIR)/bin/golangci-lint run ./...
 
 # V2
 

agency/operation_test.go

@@ -25,8 +25,9 @@ package agency_test
 import (
 	"testing"
 
-	"github.com/arangodb/go-driver/agency"
 	"github.com/stretchr/testify/require"
+
+	"github.com/arangodb/go-driver/agency"
 )
 
 func TestCreateSubKey(t *testing.T) {

encode-go_1_8.go

@@ -20,6 +20,7 @@
 // Author Ewout Prangsma
 //
 
+//go:build go1.8
 // +build go1.8
 
 package driver

encode.go

@@ -20,6 +20,7 @@
 // Author Ewout Prangsma
 //
 
+//go:build !go1.8
 // +build !go1.8
 
 package driver

example_client_test.go

@@ -20,6 +20,7 @@
 // Author Ewout Prangsma
 //
 
+//go:build !auth
 // +build !auth
 
 package driver_test

example_context_test.go

@@ -20,6 +20,7 @@
 // Author Ewout Prangsma
 //
 
+//go:build !auth
 // +build !auth
 
 package driver_test

example_create_document_test.go

@@ -20,6 +20,7 @@
 // Author Ewout Prangsma
 //
 
+//go:build !auth
 // +build !auth
 
 // This example demonstrates how to create a single document.