TTL infinity not usable

[pekeler]

The code sets the TTL to Infinity if timeToLive is falsy. But, the manifest declares a default value of 1 week making it impossible to actually use Infinity as TTL.

util-sessions-jwt/storage.js

Line 75 in 40ce08d

if (!cfg.timeToLive) {

util-sessions-jwt/manifest.json

Line 31 in 40ce08d

"default": 604800000

[pekeler]

Setting timeToLive to 0 produces a session cookie which doesn't seem to be the intent according to the documentation.

[pekeler]

I think the problem might actually be in Foxx BaseMiddleware. This line
https://github.com/arangodb/arangodb/blob/d9d6588151a4da8557c0d01a72430de37e8e1bf6/js/server/modules/%40arangodb/foxx/legacy/base_middleware.js#L133

should be more like:

var ttl = (typeof cfg.ttl === 'number') ? Math.min(cfg.ttl, 20*365*24*60*60) : undefined;

i.e. infinite becomes 20 years.