Skip to content

Commit b1c4129

Browse files
committed
First swipe at fixing one test block, this test passes with no warnings
1 parent b9a5e5d commit b1c4129

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

spec/func_tests/job_spec.rb

+10-4
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
xml = @helper.create_job_xml
2929
job = "#{@job_name_prefix}_#{num}"
3030
@job_name = job if num == 0
31-
@client.job.create(job, xml).to_i.should == 200
31+
expect(@client.job.create(job, xml).to_i).to eq(200)
3232
end
3333
rescue Exception => e
3434
puts "WARNING: Can't create jobs for preparing to spec tests"
@@ -62,14 +62,20 @@
6262
it "Should raise proper exception when the job already exists" do
6363
xml = @helper.create_job_xml
6464
name = "the_duplicate_job"
65-
@valid_post_responses.should include(
65+
expect(
66+
@valid_post_responses
67+
).to include(
6668
@client.job.create(name, xml).to_i
6769
)
68-
@client.job.list(name).include?(name).should be_truthy
70+
expect(
71+
@client.job.list(name).include?(name)
72+
).to be_truthy
6973
expect(
7074
lambda { @client.job.create(name, xml) }
7175
).to raise_error(JenkinsApi::Exceptions::JobAlreadyExists)
72-
@valid_post_responses.should include(
76+
expect(
77+
@valid_post_responses
78+
).to include(
7379
@client.job.delete(name).to_i
7480
)
7581
end

0 commit comments

Comments
 (0)