Skip to content

Commit 72e5574

Browse files
Merge pull request #117 from aquality-automation/maintenance/update-to-selenium-4.8.1
Update to Selenium 4.8.1
2 parents 83e57d0 + 3b008e9 commit 72e5574

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
<dependency>
8282
<groupId>com.github.aquality-automation</groupId>
8383
<artifactId>aquality-selenium-core</artifactId>
84-
<version>2.0.5</version>
84+
<version>2.0.6</version>
8585
</dependency>
8686

8787
<dependency>

src/main/java/aquality/selenium/browser/devtools/JavaScriptHandling.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import org.openqa.selenium.devtools.idealized.Events;
1313
import org.openqa.selenium.devtools.idealized.Javascript;
1414
import org.openqa.selenium.devtools.idealized.ScriptId;
15+
import org.openqa.selenium.devtools.idealized.target.model.SessionID;
1516
import org.openqa.selenium.devtools.v85.page.Page;
1617
import org.openqa.selenium.devtools.v85.page.model.ScriptIdentifier;
1718
import org.openqa.selenium.devtools.v85.runtime.Runtime;
@@ -111,7 +112,9 @@ private void removeInitializationScriptCore(InitializationScript script) {
111112
final Field pinnedScripts = Javascript.class.getDeclaredField("pinnedScripts");
112113
pinnedScripts.setAccessible(true);
113114
//noinspection unchecked
114-
((Map<String, ScriptId>)pinnedScripts.get(engine)).remove(script.getScriptSource());
115+
((Map<SessionID, Map<String, ScriptId>>)pinnedScripts.get(engine))
116+
.get(tools.getDevToolsSession().getCdpSession())
117+
.remove(script.getScriptSource());
115118
pinnedScripts.setAccessible(false);
116119
} catch (ReflectiveOperationException e) {
117120
AqualityServices.getLogger().fatal("Error while removing initialization script", e);

src/test/java/tests/usecases/devtools/DeviceEmulationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import aquality.selenium.browser.AqualityServices;
44
import aquality.selenium.browser.devtools.EmulationHandling;
55
import com.google.common.collect.ImmutableMap;
6-
import org.openqa.selenium.devtools.v108.emulation.Emulation;
7-
import org.openqa.selenium.devtools.v108.emulation.model.DisplayFeature;
6+
import org.openqa.selenium.devtools.v110.emulation.Emulation;
7+
import org.openqa.selenium.devtools.v110.emulation.model.DisplayFeature;
88
import org.testng.Assert;
99
import org.testng.annotations.BeforeMethod;
1010
import org.testng.annotations.Test;

src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import aquality.selenium.browser.AqualityServices;
44
import org.openqa.selenium.TimeoutException;
5-
import org.openqa.selenium.devtools.v106.network.model.ConnectionType;
5+
import org.openqa.selenium.devtools.v110.network.model.ConnectionType;
66
import org.testng.Assert;
77
import org.testng.annotations.Test;
88
import tests.BaseTest;

src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import manytools.BrowserLanguageForm;
66
import manytools.UserAgentForm;
77
import org.openqa.selenium.devtools.idealized.Network;
8-
import org.openqa.selenium.devtools.v108.emulation.Emulation;
8+
import org.openqa.selenium.devtools.v110.emulation.Emulation;
99
import org.testng.Assert;
1010
import org.testng.annotations.BeforeMethod;
1111
import org.testng.annotations.Test;

0 commit comments

Comments
 (0)