Skip to content

Commit c4f812c

Browse files
authored
Update to Selenium 4.13.0 and remove webDriverManager dependency (#90) +semver: feature
This would be the last version of aquality.selenium.core that supports Java 8, as Selenium drops support
1 parent e59c20a commit c4f812c

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

.github/workflows/release-maven-central.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454

5555
- name: Step 6 - Publish package
5656
run: |
57-
mvn -Dmaven.test.skip=true -Drevision=${{ steps.gitversion.outputs.semVer }} deploy
57+
mvn -Dmaven.test.skip=true -P release -Drevision=${{ steps.gitversion.outputs.semVer }} deploy
5858
env:
5959
MVN_CENTRAL_USERNAME: ${{ secrets.OSSRH_USERNAME }}
6060
MVN_CENTRAL_PASSWORD: ${{ secrets.OSSRH_TOKEN }}

pom.xml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -120,18 +120,12 @@
120120
<dependency>
121121
<groupId>org.seleniumhq.selenium</groupId>
122122
<artifactId>selenium-java</artifactId>
123-
<version>4.8.1</version>
124-
</dependency>
125-
<dependency>
126-
<groupId>io.github.bonigarcia</groupId>
127-
<artifactId>webdrivermanager</artifactId>
128-
<version>5.6.3</version>
129-
<scope>test</scope>
123+
<version>4.13.0</version>
130124
</dependency>
131125
<dependency>
132126
<groupId>io.appium</groupId>
133127
<artifactId>java-client</artifactId>
134-
<version>8.3.0</version>
128+
<version>8.6.0</version>
135129
<scope>test</scope>
136130
</dependency>
137131
<dependency>
@@ -264,8 +258,7 @@
264258
<configuration>
265259
<serverId>ossrh</serverId>
266260
<nexusUrl>https://s01.oss.sonatype.org/</nexusUrl>
267-
<autoReleaseAfterClose>false</autoReleaseAfterClose>
268-
<skipStagingRepositoryClose>true</skipStagingRepositoryClose>
261+
<autoReleaseAfterClose>true</autoReleaseAfterClose>
269262
</configuration>
270263
</plugin>
271264
</plugins>

src/test/java/tests/applications/browser/AqualityServices.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import aquality.selenium.core.applications.AqualityModule;
44
import com.google.inject.Injector;
5-
import io.github.bonigarcia.wdm.WebDriverManager;
65

76
public class AqualityServices extends aquality.selenium.core.applications.AqualityServices<ChromeApplication> {
87
private static final ThreadLocal<AqualityServices> INSTANCE_CONTAINER = ThreadLocal.withInitial(AqualityServices::new);
@@ -28,7 +27,6 @@ public static ChromeApplication getApplication() {
2827
}
2928

3029
private static ChromeApplication startChrome(Injector injector) {
31-
WebDriverManager.chromedriver().setup();
3230
if (injector == null) {
3331
throw new RuntimeException("cannot start Chrome without DI injector");
3432
}

src/test/java/tests/applications/browser/ChromeApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class ChromeApplication implements IApplication {
1212
private final RemoteWebDriver driver;
1313

1414
ChromeApplication(long implicitWaitSeconds) {
15-
driver = new ChromeDriver(new ChromeOptions().addArguments("--headless", "--remote-allow-origins=*"));
15+
driver = new ChromeDriver(new ChromeOptions().addArguments("--headless"));
1616
setImplicitWaitTimeout(Duration.ofSeconds(implicitWaitSeconds));
1717
}
1818

0 commit comments

Comments
 (0)