Skip to content

Commit 27b9596

Browse files
committed
Revert "replace exchange with fetchAll"
This reverts commit 8606d76.
1 parent d6eb8c5 commit 27b9596

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

optimizer/src/main/java/cn/edu/tsinghua/iginx/physical/optimizer/naive/NaivePhysicalPlanner.java

+7-8
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import cn.edu.tsinghua.iginx.conf.ConfigDescriptor;
2323
import cn.edu.tsinghua.iginx.engine.physical.memory.execute.executor.unary.stateful.AddSequenceExecutor;
24-
import cn.edu.tsinghua.iginx.engine.physical.memory.execute.executor.unary.stateful.FetchAllUnaryExecutor;
2524
import cn.edu.tsinghua.iginx.engine.physical.memory.execute.executor.unary.stateful.LimitUnaryExecutor;
2625
import cn.edu.tsinghua.iginx.engine.physical.memory.execute.executor.unary.stateful.RemoveNullColumnExecutor;
2726
import cn.edu.tsinghua.iginx.engine.physical.memory.execute.executor.unary.stateless.ValueToSelectedPathExecutor;
@@ -183,13 +182,13 @@ public PhysicalTask<BatchStream> construct(
183182
public PhysicalTask<BatchStream> fetchAsync(Source source, RequestContext context) {
184183
PhysicalTask<?> sourceTask = fetch(source, context);
185184
// TODO: 是否所有的情况都应当使用 Exchange? 是否存在一些情况使用 FetchAll 更好?
186-
return new UnarySinkMemoryPhysicalTask(
187-
convert(sourceTask, context, BatchStream.class),
188-
Collections.emptyList(),
189-
context,
190-
(ctx, schema) -> new FetchAllUnaryExecutor(ctx, schema.raw()));
191-
// return new FetchAsyncMemoryPhysicalTask(
192-
// convert(sourceTask, context, BatchStream.class), context);
185+
// return new UnarySinkMemoryPhysicalTask(
186+
// convert(sourceTask, context, BatchStream.class),
187+
// Collections.emptyList(),
188+
// context,
189+
// (ctx, schema) -> new FetchAllUnaryExecutor(ctx, schema.raw()));
190+
return new FetchAsyncMemoryPhysicalTask(
191+
convert(sourceTask, context, BatchStream.class), context);
193192
}
194193

195194
public PhysicalTask<BatchStream> construct(CombineNonQuery operator, RequestContext context) {

0 commit comments

Comments
 (0)