Skip to content
This repository was archived by the owner on May 10, 2019. It is now read-only.

Roles without compliance tools see a compliance owner role in their list of roles #710

Open
gib opened this issue Aug 29, 2016 · 5 comments
Assignees

Comments

@gib
Copy link
Contributor

gib commented Aug 29, 2016

When viewing org members in dashboard, all roles for a member are listed. In the roles migration, admins got put in compliance owner roles regardless of the organization having gridiron / compliance tool access -- Not true.

screen shot 2016-08-29 at 3 13 36 pm

This list a "compliance owner" role for account owners in orgs that do not have gridiron. They can't view or remove this memberships.

@gib gib self-assigned this Aug 29, 2016
@skylar-anderson
Copy link
Contributor

This list a "compliance owner" role for account owners in orgs that do not have gridiron. They can't view or remove this memberships.

Even if they click on the edit button and edit that way?

@gib
Copy link
Contributor Author

gib commented Sep 5, 2016

@sandersonet - I forgot to update here. I looked back over our migrations. We had not intended orgs without Gridiron to have the role. I removed the compliance owner role from the org that created the issue. So the org either:

  • downgraded and the compliance owner role removal needs to be added to that process
    OR
  • the role was added by accident and we need to query out any orgs with the role that shouldn't have it

I was working on the second here and planned to discuss with @fancyremarker.

@skylar-anderson
Copy link
Contributor

We had not intended orgs without Gridiron to have the role.

Interesting. The current organization bootstrapping logic actually creates the compliance owners role regardless of current plan. I think going forward though, only organizations that were once Pilot+ that then downgraded to Platform- will see the role.

I'm only brining this up because I'm not sure adding the logic to filter role visibility based on plan is worth the added complexity--Although it would be much easier using the authorization service.

@gib
Copy link
Contributor Author

gib commented Sep 5, 2016

So new orgs will always get both roles? I agree, that's where we should fix it

@fancyremarker
Copy link
Member

@gib: I think our original thinking was that we would indeed create the "Compliance Owners" role for all new organizations, to (a) have only one "bootstrapper" and (b) reduce the number of steps that need to happen when a customer upgrades to Pilot+.

I'm okay changing that, but just wanted to point out that the existing behavior is intentional, if not ideal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants