This repository was archived by the owner on May 10, 2019. It is now read-only.
Dashboard users need to be able to remove a role #641
Comments
krallin
added a commit
to krallin/dashboard.aptible.com
that referenced
this issue
Jul 11, 2016
When a user attempts to log in without being a member of an organization, we currently throw a `TypeError`, which is problematic for a few reasons: - First, it doesn't let the user log out (without manually deleting cookies), which is bad from a security standpoint (they might not even realize they're still logged in). - Second, it's very confusing: it's very unclear why they're receiving a `TypeError`. In practice this shouldn't happen very often, but it *can* happen if a user attempts to verify their email before accepting an invitation (https://github.com/aptible/auth.aptible.com/pull/225 is evidence that some people do), in which case we should send them back on the happy path, i.e. tell them to accept the invitation. - Third, it might start happening more often if / when we let users remove other users from their organization (aptible#642, aptible#641)
krallin
added a commit
to krallin/dashboard.aptible.com
that referenced
this issue
Jul 12, 2016
When a user attempts to log in without being a member of an organization, we currently throw a `TypeError`, which is problematic for a few reasons: - First, it doesn't let the user log out (without manually deleting cookies), which is bad from a security standpoint (they might not even realize they're still logged in). - Second, it's very confusing: it's very unclear why they're receiving a `TypeError`. In practice this shouldn't happen very often, but it *can* happen if a user attempts to verify their email before accepting an invitation (https://github.com/aptible/auth.aptible.com/pull/225 is evidence that some people do), in which case we should send them back on the happy path, i.e. tell them to accept the invitation. - Third, it might start happening more often if / when we let users remove other users from their organization (aptible#642, aptible#641)
krallin
added a commit
to krallin/dashboard.aptible.com
that referenced
this issue
Jul 13, 2016
When a user attempts to log in without being a member of an organization, we currently throw a `TypeError`, which is problematic for a few reasons: - First, it doesn't let the user log out (without manually deleting cookies), which is bad from a security standpoint (they might not even realize they're still logged in). - Second, it's very confusing: it's very unclear why they're receiving a `TypeError`. In practice this shouldn't happen very often, but it *can* happen if a user attempts to verify their email before accepting an invitation (https://github.com/aptible/auth.aptible.com/pull/225 is evidence that some people do), in which case we should send them back on the happy path, i.e. tell them to accept the invitation. - Third, it might start happening more often if / when we let users remove other users from their organization (aptible#642, aptible#641)
krallin
added a commit
to krallin/dashboard.aptible.com
that referenced
this issue
Jul 13, 2016
When a user attempts to log in without being a member of an organization, we currently throw a `TypeError`, which is problematic for a few reasons: - First, it doesn't let the user log out (without manually deleting cookies), which is bad from a security standpoint (they might not even realize they're still logged in). - Second, it's very confusing: it's very unclear why they're receiving a `TypeError`. In practice this shouldn't happen very often, but it *can* happen if a user attempts to verify their email before accepting an invitation (https://github.com/aptible/auth.aptible.com/pull/225 is evidence that some people do), in which case we should send them back on the happy path, i.e. tell them to accept the invitation. - Third, it might start happening more often if / when we let users remove other users from their organization (aptible#642, aptible#641)
krallin
added a commit
to krallin/dashboard.aptible.com
that referenced
this issue
Jul 13, 2016
When a user attempts to log in without being a member of an organization, we currently throw a `TypeError`, which is problematic for a few reasons: - First, it doesn't let the user log out (without manually deleting cookies), which is bad from a security standpoint (they might not even realize they're still logged in). - Second, it's very confusing: it's very unclear why they're receiving a `TypeError`. In practice this shouldn't happen very often, but it *can* happen if a user attempts to verify their email before accepting an invitation (https://github.com/aptible/auth.aptible.com/pull/225 is evidence that some people do), in which case we should send them back on the happy path, i.e. tell them to accept the invitation. - Third, it might start happening more often if / when we let users remove other users from their organization (aptible#642, aptible#641)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This process must ensure that the user is notified if this will orphan users when the role is deleted. If any of the deleted role's members are not members of any other role, they're orphaned.
Currently the select that provides users that can be added to a role is built from
organization.get('users'), which would allow users with no other memberships to be added to a different role, but we may be assuming all users have at least one role. Should we be deleting users in this case? Asking the user that initiated the delete if they would like to delete those users? Hell of a confirm dialog... will need design / discussion.The text was updated successfully, but these errors were encountered: