Duplicates line number showing

Author: sohelamin

.gitignore

@@ -2,4 +2,4 @@ vendor
 temp
 composer.lock
 .DS_STORE
-create-phar.php
+generate-phar.php

README.md

@@ -46,7 +46,6 @@ $ phpcloc duplicate directory --ext=php --exclude=vendor
 ```
 
 ## Todo
-- Line number show on duplicate code checker command
 - Improve algorithm complexity
 - Testing
 

src/Analyzers/DuplicateAnalyzer.php

@@ -66,62 +66,31 @@ protected function processLines(SplFileObject $file)
         $filename = $file->getPathname();
 
         $lines = [];
-        $totalLines = 0;
-        $isMultilines = false;
-        while ($file->valid()) {
-            $currentLine = $file->fgets();
-            $trimLine = trim($currentLine);
-            $lineProperties = [];
-
-            // Ignoring the last new line
-            if ($file->eof() && empty($trimLine)) {
-                break;
-            }
-
-            $totalLines ++;
-            if (empty($trimLine)) {
-                $lineProperties['blank'] = true;
+        $duplicates = [];
+        foreach ($file as $line) {
+            $trimLine = trim($line);
+            $lineNo = ($file->key() + 1);
+
+            if ($foundIndex = array_search($trimLine, array_column($lines, 'code'))) {
+                $duplicates[] = $lines[$foundIndex]['lineNo'];
+                $duplicates[] = $lineNo;
             }
 
-            // Detecting comments
-            if (strpos($trimLine, '//') === 0
-                || strpos($trimLine, '#') === 0) {
-                $lineProperties['comment'] = true;
-            }
-
-            // Detecting multilines comments
-            if (strpos($trimLine, '/*') === 0) {
-                $isMultilines = true;
-            }
-            if ($isMultilines) {
-                $lineProperties['comment'] = true;
-            }
-            if (strpos($trimLine, '*/') === 0) {
-                $isMultilines = false;
+            if (strlen($trimLine) > 3) {
+                $lines[] = [
+                    'lineNo' => $lineNo,
+                    'code' => $trimLine,
+                ];
             }
-
-            $lineProperties['code'] = $currentLine;
-            $lines[] = $lineProperties;
         }
 
-        $code = array_filter($lines, function ($line) {
-            if (isset($line['blank']) || isset($line['comment'])) {
-                return false;
-            }
-
-            return true;
-        });
-
-        $codeFlatten = array_column($code, 'code');
-        $totalCode = count($codeFlatten);
-        $totalUniqueCode = count(array_unique($codeFlatten));
-        $duplicate = $totalCode - $totalUniqueCode;
-
-        if ($duplicate > 0) {
+        $totalDuplicates = count($duplicates);
+        if ($totalDuplicates > 0) {
+            sort($duplicates);
             $this->stats[$filename] = [
                 'file' => $filename,
-                'line' => $totalLines,
-                'duplicate' => $duplicate,
+                'duplicate' => $totalDuplicates,
+                'line_no' => implode(',', $duplicates),
             ];
         }
     }

src/Commands/ClocCommand.php

@@ -52,6 +52,11 @@ public function execute(InputInterface $input, OutputInterface $output)
         $exclude = $input->getOption('exclude');
 
         $stats = array_values((new ClocAnalyzer($path, $ext, $exclude))->stats());
+        if (count($stats) === 0) {
+            $output->writeln('No files found.');
+            return;
+        }
+
         array_push(
             $stats,
             new TableSeparator(),

src/Commands/DuplicateCommand.php

@@ -8,6 +8,7 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Helper\TableSeparator;
+use Symfony\Component\Console\Helper\TableCell;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputOption;
 
@@ -53,23 +54,28 @@ public function execute(InputInterface $input, OutputInterface $output)
         $exclude = $input->getOption('exclude');
 
         $stats = (new DuplicateAnalyzer($path, $ext, $exclude))->stats();
+        if (count($stats) === 0) {
+            $output->writeln('No files found.');
+            return;
+        }
+
         array_push(
             $stats,
             new TableSeparator(),
             [
                 'Total',
-                array_reduce($stats, function ($carry, $item) {
-                    return $carry + $item['line'];
-                }),
-                array_reduce($stats, function ($carry, $item) {
-                    return $carry + $item['duplicate'];
-                }),
+                new TableCell(
+                    array_reduce($stats, function ($carry, $item) {
+                        return $carry + $item['duplicate'];
+                    }),
+                    ['colspan' => 2]
+                ),
             ]
         );
 
         $table = new Table($output);
         $table
-            ->setHeaders(['File', 'Line', 'Duplicate'])
+            ->setHeaders(['File', 'Duplicate', 'In Line(s)'])
             ->setRows($stats)
         ;
         $table->render();