-
Notifications
You must be signed in to change notification settings - Fork 0
Allow an ENV var for APPPACK_TOML to specify the path to the toml file. See Issue #10 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3842cf3 to
a9d1261
Compare
|
This looks correct to me. What do you think about factoring this out into a small function? filename := "apppack.toml"
if envFile := os.Getenv("APPPACK_TOML"); envFile != "" {
filename = envFile
}That would be something that we (or your favorite LLM) could add a simple test for. If the tests pass, we can deploy to a canary environment. I can help with that next week. |
Great. What about docs or changelogs for the new behavior? |
a9d1261 to
5dd49d6
Compare
5dd49d6 to
7a75a5c
Compare
|
This MR updated and also: |
CHANGELOG.md
Outdated
|
|
||
| ## [2.2.0] - 2025-06-12 | ||
|
|
||
| ### Improved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a list of headers here at https://keepachangelog.com/en/1.1.0/#how
I would use Added
builder/build/prebuild.go
Outdated
| if appJsonExists && !apppackTomlExists { | ||
| // convert app.json to apppack.toml | ||
| b.Log().Info().Msg("Converting app.json to apppack.toml") | ||
| b.Log().Info().Msg(fmt.Sprintf("Converting %s to %s", "app.json", filename)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is app.json substituted here?
* Update changelog verb. * Unset env var after test. * Fix an unnecessary string formatt
|
These commits should be squashed before merging. |
Draft, not yet tested. Pushing to see what parts get built/run/tested automatically on branches