Fix release task extraction from Heroku buildpack

Author: ipmb

CHANGELOG.md

@@ -0,0 +1,12 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [2.1.0] - 2025-02-10
+
+### Fixed
+
+* Release tasks work with latest metadata from Heroku Buildpacks

builder/build/metadatatoml.go

@@ -32,7 +32,7 @@ func (m *BuildpackMetadataToml) UpdateAppPackToml(a *AppPackToml) {
 	a.Services = make(map[string]AppPackTomlService)
 	for _, process := range m.Processes {
 		if process.Type == "release" {
-			a.Deploy.ReleaseCommand = commandSliceToString(process.Command)
+			a.Deploy.ReleaseCommand = commandSliceToString(append(process.Command, process.Args...))
 			continue
 		}
 		if process.BuildpackID == "heroku/ruby" && (process.Type == "rake" || process.Type == "console") {

builder/build/metadatatoml_test.go

@@ -8,22 +8,26 @@ func TestBuildpackMetadataTomlToApppackServices(t *testing.T) {
 	m := BuildpackMetadataToml{
 		Processes: []BuildpackMetadataTomlProcess{
 			{
-				Command:     []string{"echo", "ruby web"},
+				Command:     []string{"bash", "-c"},
+				Args:        []string{"echo \"ruby web\""},
 				Type:        "web",
 				BuildpackID: "heroku/ruby",
 			},
 			{
-				Command:     []string{"echo", "release"},
+				Command:     []string{"bash", "-c"},
+				Args:        []string{"echo release"},
 				Type:        "release",
 				BuildpackID: "heroku/ruby",
 			},
 			{
-				Command:     []string{"echo 'ruby worker'"},
+				Command:     []string{"bash", "-c"},
+				Args:        []string{"echo 'ruby worker'"},
 				Type:        "worker",
 				BuildpackID: "heroku/ruby",
 			},
 			{
-				Command:     []string{"echo", "rake"},
+				Command:     []string{"bash", "-c"},
+				Args:        []string{"echo rake"},
 				Type:        "rake",
 				BuildpackID: "heroku/ruby",
 			},
@@ -34,15 +38,15 @@ func TestBuildpackMetadataTomlToApppackServices(t *testing.T) {
 	if len(a.Services) != 2 {
 		t.Errorf("expected 2 services, got %d", len(a.Services))
 	}
-	expected := "echo 'ruby web'"
+	expected := "bash -c 'echo \"ruby web\"'"
 	if a.Services["web"].Command != expected {
 		t.Errorf("expected %s, got %s", expected, a.Services["web"].Command)
 	}
-	expected = "echo 'ruby worker'"
+	expected = "bash -c 'echo '\"'\"'ruby worker'\"'\"''"
 	if a.Services["worker"].Command != expected {
 		t.Errorf("expected %s, got %s", expected, a.Services["worker"].Command)
 	}
-	expected = "echo release"
+	expected = "bash -c 'echo release'"
 	if a.Deploy.ReleaseCommand != expected {
 		t.Errorf("expected %s, got %s", expected, a.Deploy.ReleaseCommand)
 	}