Conform Logger.Level to CustomStringConvertible and LosslessStringConvertible
#395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngConvertible`. Motivation: There are libraries, such as Vapor, that add these conformances privately and `@retroactive`ly. This would avoid having to implement these conformances manually in each library and would unify and standardise the implementation. Modifications: Make `Logger.Level` conform to `CustomStringConvertible` and `LosslessStringConvertible`, adding a public `description` computed property that returns the `rawValue` and a public initializer that takes a `description` string, lowercases it, and passes it to the `rawValue` initializer. Result: `Logger.Level` conforms to `CustomStringConvertible` and `LosslessStringConvertible`.
czechboy0
approved these changes
Dec 7, 2025
Contributor
czechboy0
left a comment
czechboy0
left a comment
There was a problem hiding this comment.
Oh I've wanted this for so long, just never got to open a PR - thank you @fpseverino 🙂
Contributor
Author
|
I'm afraid I can't add the required label to the PR to make the CI pass |
FranzBusch
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conform
Logger.LeveltoCustomStringConvertibleandLosslessStringConvertible.Motivation:
There are libraries, such as Vapor, that add these conformances privately and
@retroactively. This would avoid having to implement these conformances manually in each library and would unify and standardise the implementation.Modifications:
Make
Logger.Levelconform toCustomStringConvertibleandLosslessStringConvertible, adding a publicdescriptioncomputed property that returns therawValueand a public initializer that takes adescriptionstring, lowercases it, and passes it to therawValueinitializer.Result:
Logger.Levelconforms toCustomStringConvertibleandLosslessStringConvertible.