Skip to content

Commit 52d3add

Browse files
committed
Tracer.withSpan's isolation param should be 'isolated'
**Motivation:** The intent of this parameter is to not cross an isolation boundary when calling withSpan, thus, we were missing the isolated modifier in this protocol. **Modifications:** Make the `isolation: (any Actor)? = #isolation,` parameter 'isolated', as was originally intended **Result:** Not crossing actor boundary when calling this method means less errors when adopting Swift 6 mode, and correct behavior of these functions
1 parent eec7ac7 commit 52d3add

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Sources/Tracing/TracerProtocol+Legacy.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ extension LegacyTracer {
404404
_ operationName: String,
405405
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
406406
ofKind kind: SpanKind = .internal,
407-
isolation: (any Actor)? = #isolation,
407+
isolation: isolated (any Actor)? = #isolation,
408408
function: String = #function,
409409
file fileID: String = #fileID,
410410
line: UInt = #line,
@@ -610,7 +610,7 @@ extension Tracer {
610610
at instant: @autoclosure () -> some TracerInstant = DefaultTracerClock.now,
611611
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
612612
ofKind kind: SpanKind = .internal,
613-
isolation: (any Actor)? = #isolation,
613+
isolation: isolated (any Actor)? = #isolation,
614614
function: String = #function,
615615
file fileID: String = #fileID,
616616
line: UInt = #line,

Sources/Tracing/TracerProtocol.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ extension Tracer {
263263
_ operationName: String,
264264
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
265265
ofKind kind: SpanKind = .internal,
266-
isolation: (any Actor)? = #isolation,
266+
isolation: isolated (any Actor)? = #isolation,
267267
function: String = #function,
268268
file fileID: String = #fileID,
269269
line: UInt = #line,
@@ -353,7 +353,7 @@ extension Tracer {
353353
context: @autoclosure () -> ServiceContext = .current ?? .topLevel,
354354
ofKind kind: SpanKind = .internal,
355355
at instant: @autoclosure () -> some TracerInstant = DefaultTracerClock.now,
356-
isolation: (any Actor)? = #isolation,
356+
isolation: isolated (any Actor)? = #isolation,
357357
function: String = #function,
358358
file fileID: String = #fileID,
359359
line: UInt = #line,

0 commit comments

Comments
 (0)