Skip to content

Commit 3224f5a

Browse files
authored
remove always_match and use first_match instead (#246)
remove always_match and use first_match instead
1 parent feb4b04 commit 3224f5a

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

appium/webdriver/webdriver.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,26 +67,26 @@ def _make_w3c_caps(caps):
6767

6868
caps = copy.deepcopy(caps)
6969
profile = caps.get('firefox_profile')
70-
always_match = {}
70+
first_match = {}
7171
if caps.get('proxy') and caps['proxy'].get('proxyType'):
7272
caps['proxy']['proxyType'] = caps['proxy']['proxyType'].lower()
7373
for k, v in caps.items():
7474
if v and k in _OSS_W3C_CONVERSION:
75-
always_match[_OSS_W3C_CONVERSION[k]] = v.lower() if k == 'platform' else v
75+
first_match[_OSS_W3C_CONVERSION[k]] = v.lower() if k == 'platform' else v
7676
if k in _W3C_CAPABILITY_NAMES or _EXTENSION_CAPABILITY in k:
77-
always_match[k] = v
77+
first_match[k] = v
7878
else:
7979
if not k.startswith(appium_prefix):
80-
always_match[appium_prefix + k] = v
80+
first_match[appium_prefix + k] = v
8181
if profile:
82-
moz_opts = always_match.get('moz:firefoxOptions', {})
82+
moz_opts = first_match.get('moz:firefoxOptions', {})
8383
# If it's already present, assume the caller did that intentionally.
8484
if 'profile' not in moz_opts:
8585
# Don't mutate the original capabilities.
8686
new_opts = copy.deepcopy(moz_opts)
8787
new_opts['profile'] = profile
88-
always_match['moz:firefoxOptions'] = new_opts
89-
return {'firstMatch': [{}], 'alwaysMatch': always_match}
88+
first_match['moz:firefoxOptions'] = new_opts
89+
return {'firstMatch': [first_match]}
9090

9191

9292
class WebDriver(webdriver.Remote):

0 commit comments

Comments
 (0)