Skip to content

Commit a60a7cc

Browse files
authored
build: Restore execution of lost tests (#2139)
1 parent 75e7262 commit a60a7cc

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

build.gradle

+2
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ test {
207207
includeTestsMatching 'io.appium.java_client.drivers.options.*'
208208
includeTestsMatching 'io.appium.java_client.events.*'
209209
includeTestsMatching 'io.appium.java_client.internal.*'
210+
includeTestsMatching 'io.appium.java_client.pagefactory_tests.DesktopBrowserCompatibilityTest'
211+
includeTestsMatching 'io.appium.java_client.pagefactory_tests.TimeoutTest'
210212
includeTestsMatching 'io.appium.java_client.proxy.*'
211213
includeTestsMatching 'io.appium.java_client.remote.*'
212214
includeTestsMatching 'io.appium.java_client.touch.*'

src/test/java/io/appium/java_client/TestUtils.java

+6-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import java.net.DatagramSocket;
1111
import java.net.InetAddress;
1212
import java.net.SocketException;
13+
import java.net.URISyntaxException;
1314
import java.net.URL;
1415
import java.net.UnknownHostException;
1516
import java.nio.file.Files;
@@ -35,7 +36,11 @@ public static Path resourcePathToLocalPath(String resourcePath) {
3536
if (url == null) {
3637
throw new IllegalArgumentException(String.format("Cannot find the '%s' resource", resourcePath));
3738
}
38-
return Paths.get(url.getPath());
39+
try {
40+
return Paths.get(url.toURI());
41+
} catch (URISyntaxException e) {
42+
throw new IllegalArgumentException(e);
43+
}
3944
}
4045

4146
public static String resourceAsString(String resourcePath) {

src/test/java/io/appium/java_client/pagefactory_tests/DesktopBrowserCompatibilityTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.openqa.selenium.WebDriver;
2727
import org.openqa.selenium.WebElement;
2828
import org.openqa.selenium.chrome.ChromeDriver;
29+
import org.openqa.selenium.chrome.ChromeOptions;
2930
import org.openqa.selenium.support.FindBy;
3031
import org.openqa.selenium.support.FindBys;
3132
import org.openqa.selenium.support.PageFactory;
@@ -58,7 +59,7 @@ public class DesktopBrowserCompatibilityTest {
5859
}
5960

6061
@Test public void chromeTest() {
61-
WebDriver driver = new ChromeDriver();
62+
WebDriver driver = new ChromeDriver(new ChromeOptions().addArguments("--headless=new"));
6263
try {
6364
PageFactory.initElements(new AppiumFieldDecorator(driver, ofSeconds(15)), this);
6465
driver.get(helloAppiumHtml().toUri().toString());

src/test/java/io/appium/java_client/pagefactory_tests/TimeoutTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.openqa.selenium.WebDriver;
2626
import org.openqa.selenium.WebElement;
2727
import org.openqa.selenium.chrome.ChromeDriver;
28+
import org.openqa.selenium.chrome.ChromeOptions;
2829
import org.openqa.selenium.support.FindAll;
2930
import org.openqa.selenium.support.FindBy;
3031

@@ -86,7 +87,7 @@ public static void beforeAll() {
8687
* The setting up.
8788
*/
8889
@BeforeEach public void setUp() {
89-
driver = new ChromeDriver();
90+
driver = new ChromeDriver(new ChromeOptions().addArguments("--headless=new"));
9091
timeOutDuration = DEFAULT_WAITING_TIMEOUT;
9192
initElements(new AppiumFieldDecorator(driver, timeOutDuration), this);
9293
}

0 commit comments

Comments
 (0)