typo: portal access admin service #5305
Conversation
dosubot
bot
added
the
size:XS
WalkthroughThe pull request updates the Apollo design documentation in both English and Chinese versions, focusing on correcting the service interaction sequence between the Portal and the services. The key modification involves changing the documentation to show that the Portal now sends requests directly to the Admin Service instead of the Config Service, reflecting an updated communication flow in the Apollo system's architecture. Changes
Sequence DiagramsequenceDiagram
participant Portal
participant AdminService
Portal ->> AdminService: Request configuration
AdminService -->> Portal: Acknowledge request
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/zh/design/apollo-design.md (1)
81-82: LGTM! Documentation now correctly shows Portal accessing Admin Service.The sequence diagram update accurately reflects the intended architecture where Portal interacts with Admin Service for configuration management tasks.
Replace hard tabs with spaces for consistent formatting:
- Portal ->> Admin Service: request - Admin Service -->> Portal: ack + Portal ->> Admin Service: request + Admin Service -->> Portal: ack🧰 Tools
🪛 Markdownlint (0.37.0)
81-81: Column: 1
Hard tabs(MD010, no-hard-tabs)
82-82: Column: 1
Hard tabs(MD010, no-hard-tabs)
docs/en/design/apollo-design.md (1)
77-78: LGTM! Documentation now correctly shows Portal accessing Admin Service.The sequence diagram update in the English documentation matches the Chinese version and accurately reflects the intended architecture.
Replace hard tabs with spaces for consistent formatting:
- Portal ->> Admin Service: request - Admin Service -->> Portal: ack + Portal ->> Admin Service: request + Admin Service -->> Portal: ack🧰 Tools
🪛 Markdownlint (0.37.0)
77-77: Column: 3
Hard tabs(MD010, no-hard-tabs)
78-78: Column: 3
Hard tabs(MD010, no-hard-tabs)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/en/design/apollo-design.md(1 hunks)docs/zh/design/apollo-design.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
docs/en/design/apollo-design.md
77-77: Column: 3
Hard tabs
(MD010, no-hard-tabs)
78-78: Column: 3
Hard tabs
(MD010, no-hard-tabs)
docs/zh/design/apollo-design.md
81-81: Column: 1
Hard tabs
(MD010, no-hard-tabs)
82-82: Column: 1
Hard tabs
(MD010, no-hard-tabs)
What's the purpose of this PR
Fixed a error in sequence diagram.
Which issue(s) this PR fixes:
Fixes #
Brief changelog
Fixed a error in sequence diagram. Portal should access admin service, not config service.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit