Skip to content

Commit 84028ee

Browse files
committed
Removed status code intersection
Asserting type within the tests instead of the runtime leads to more exact runtime types without breaking the test
1 parent 823f4b3 commit 84028ee

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/__tests__/integrationALB.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
CreateServerForIntegrationTestsOptions,
44
defineIntegrationTestSuite,
55
} from '@apollo/server-integration-testsuite';
6+
import type { ALBEvent, ALBResult, Handler } from 'aws-lambda';
67
import { createServer } from 'http';
78
import { startServerAndCreateLambdaHandler } from '..';
89
import { createMockALBServer } from './mockALBServer';
@@ -23,7 +24,10 @@ describe('lambdaHandlerALB', () => {
2324
? startServerAndCreateLambdaHandler(server, testOptions)
2425
: startServerAndCreateLambdaHandler(server);
2526

26-
httpServer.addListener('request', createMockALBServer(handler));
27+
httpServer.addListener(
28+
'request',
29+
createMockALBServer(handler as Handler<ALBEvent, ALBResult>),
30+
);
2731

2832
await new Promise<void>((resolve) => {
2933
httpServer.listen({ port: 0 }, resolve);

src/index.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,10 @@ export interface LambdaHandlerOptions<TContext extends BaseContext> {
3636
context?: ContextFunction<[LambdaContextFunctionArgument], TContext>;
3737
}
3838

39-
export type HandlerResult = (
39+
export type HandlerResult =
4040
| APIGatewayProxyStructuredResultV2
4141
| APIGatewayProxyResult
42-
| ALBResult
43-
) & {
44-
statusCode: number;
45-
};
42+
| ALBResult;
4643

4744
type LambdaHandler = Handler<IncomingEvent, HandlerResult>;
4845

0 commit comments

Comments
 (0)