Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 11 ConfigForms fixes as New parameter added to ConfigFormBase::__construct #1108

Open
kedarkhaire opened this issue Jan 16, 2025 · 0 comments
Assignees
Labels
Drupal 11 enhancement New feature or request

Comments

@kedarkhaire
Copy link
Collaborator

kedarkhaire commented Jan 16, 2025

Is your feature request related to a problem? Please describe.

As per the Drupal 11 release, the \Drupal\Core\Form\ConfigFormBase::__construct now accepts a $typedConfigManager argument. This argument must be an instance of \Drupal\Core\Config\TypedConfigManagerInterface. It is optional in 10.2 and will be required in 11.0.
To make our module compatible, we have to update all configuration form with the required change.

Link of change record - https://www.drupal.org/comment/reply/3404140

Fixes needed on the following Apigee Admin Configuration Forms (Admin > Configuration > Apigee)

  1. AppSettingsForm.php (Apigee > Apps > General)
  2. EdgeEntityDisplaySettingsForm.php (Apigee > Apps > Developer Apps > Display Settings)
  3. DeveloperAttributesSettingsForm.php (Apigee > Developer > Custom Attributes)
  4. ApiProductAccessControlForm.php (Apigee > Api Products > Api Product Access)
  5. apigee_edge_debug/src/Form/ConfigForm.php (Apigee > Debug)

Describe the solution you would like

  1. Classes extending ConfigFormBase and that do not override the constructor do not need to change anything now nor in the future: they automatically inherit this new behavior.
  2. Classes extending ConfigFormBase that do override the constructor will need to update this by Drupal 11.
  3. Classes that have a $typedConfigManager property continue to work fine in Drupal 10 thanks to the base class' property not being typehinted, but will need to be updated by Drupal 11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal 11 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants