Skip to content

Commit 65a1361

Browse files
committed
Request loaders use async getters for handled/total req cnt
1 parent 30890f0 commit 65a1361

File tree

4 files changed

+12
-20
lines changed

4 files changed

+12
-20
lines changed

src/crawlee/request_loaders/_request_list.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,12 @@ def __init__(
5454
def name(self) -> str | None:
5555
return self._name
5656

57-
@property
5857
@override
59-
async def handled_count(self) -> int:
58+
async def get_handled_count(self) -> int:
6059
return self._handled_count
6160

62-
@property
6361
@override
64-
async def total_count(self) -> int:
62+
async def get_total_count(self) -> int:
6563
return self._assumed_total_count
6664

6765
@override

src/crawlee/request_loaders/_request_loader.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,13 @@ class RequestLoader(ABC):
2525
- Managing state information such as the total and handled request counts.
2626
"""
2727

28-
@property
2928
@abstractmethod
30-
async def handled_count(self) -> int:
31-
"""The number of requests that have been handled."""
29+
async def get_handled_count(self) -> int:
30+
"""Get the number of requests in the loader that have been handled."""
3231

33-
@property
3432
@abstractmethod
35-
async def total_count(self) -> int:
36-
"""The total number of requests in the loader."""
33+
async def get_total_count(self) -> int:
34+
"""Get the total number of requests in the loader (i.e. pending + handled)."""
3735

3836
@abstractmethod
3937
async def is_empty(self) -> bool:

src/crawlee/request_loaders/_request_manager_tandem.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,13 @@ def __init__(self, request_loader: RequestLoader, request_manager: RequestManage
3232
self._read_only_loader = request_loader
3333
self._read_write_manager = request_manager
3434

35-
@property
3635
@override
37-
async def handled_count(self) -> int:
38-
return await self._read_write_manager.handled_count
36+
async def get_handled_count(self) -> int:
37+
return await self._read_write_manager.get_handled_count()
3938

40-
@property
4139
@override
42-
async def total_count(self) -> int:
43-
return (await self._read_only_loader.total_count) + (await self._read_write_manager.total_count)
40+
async def get_total_count(self) -> int:
41+
return (await self._read_only_loader.get_total_count()) + (await self._read_write_manager.get_total_count())
4442

4543
@override
4644
async def is_empty(self) -> bool:

src/crawlee/storages/_request_queue.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,12 @@ def name(self) -> str | None:
108108
def metadata(self) -> RequestQueueMetadata:
109109
return self._client.metadata
110110

111-
@property
112111
@override
113-
async def handled_count(self) -> int:
112+
async def get_handled_count(self) -> int:
114113
return self._client.metadata.handled_request_count
115114

116-
@property
117115
@override
118-
async def total_count(self) -> int:
116+
async def get_total_count(self) -> int:
119117
return self._client.metadata.total_request_count
120118

121119
@override

0 commit comments

Comments
 (0)