Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: At the end of tuning script, the resulting config file does not retain comments from the original config file. #372

Open
LucasDedieu opened this issue Feb 10, 2025 · 0 comments · May be fixed by #373
Open

fix: At the end of tuning script, the resulting config file does not retain comments from the original config file. #372

LucasDedieu opened this issue Feb 10, 2025 · 0 comments · May be fixed by #373
Assignees
@LucasDedieu

Comments

@LucasDedieu
Copy link
Collaborator

Description

At the end of tuning script, the resulting config file does not retain comments from the original config file.

How to reproduce the bug

  1. Launch a tuning process using a config file that contains comments.
  2. At the end of tuning, the resulting config file in output_dir has lost all comments.
@LucasDedieu LucasDedieu self-assigned this Feb 10, 2025
@LucasDedieu LucasDedieu linked a pull request Feb 10, 2025 that will close this issue
Fix issue 372: resulting tuning config file now preserve comments #373
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucasDedieu LucasDedieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue 372: resulting tuning config file now preserve comments aphp/edsnlp
1 participant
@LucasDedieu